Add support for snapshotting multiple devices in one go #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really like the PR, would be a great addition ;) |
stefanceriu
force-pushed
the
stefan/multipleDeviceSupportPart2
branch
from
0d168b4 to
7ef3ca1
Compare
|
Alrighty, with 37 out of the way I had no problem setting this up in Element X, just a few configuration changes. We now have 1000 new shiny snapshots element-hq/element-x-ios@6ea320e It's especially nice to see one in which the size classes actually matter, like this split view test we have: iPad vs iPhone Otherwise, I've updated the version and binary. Anything else I need to do before we can get this merged? |
|
Let's add information about the new feature in Readme.md?) |
|
Oh, of course. I've added something, have a look please |
|
Bump 👋 |
|
@stefanceriu Congratulations on the completed Merge Request 🥳 Thank you so much for such a cool feature! ❤️ |
|
Yey, it was my absolute pleasure! Thank you too! 🥳 |
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me just start by saying that we're absolutely delighted by Prefire so thank you very much for making it happen! 👏
We've been using it for quite some time now in Element X with great success and we would like to take it one step further.
We're currently also using UI tests to snapshot multiple devices and languages but those are more cumbersome to setup and run so we would like to switch them to Prefire too.
We can do so by building custom ViewImageConfigs and simulate other devices no matter what simulator you're running on, which is what this PR aims to add. Different languages can be handled by adding extra xctestplan configurations and running the generated tests multiple times + a small tweak to the tests template to include the language in the screenshot name e.g. https://github.com/element-hq/element-x-ios/blob/develop/UITests/Sources/Application.swift#L74
It seems to be working well for the Prefire Example project and I would try it out in Element X but I'm blocked on #37. I do have another implementation of this based on Prefire 1 which worked just fine so I have no reason to believe it won't do the job.
Hope this all makes sense and that I'm not missing anything.
P.S. I also tried removing
checkEnvironmentsentirely and let you run on any simulator but there's weird text rendering kerning issues between devices that I wasn't able to figure out. For example the iPhone 15 family works no matter which one you chose but iPads an iPhone SE renders text slightly differently, enough to break the tests.