Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: make aliases load very late #2043

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Jan 13, 2022

WORK-IN-PROGRESS: this needs to have unrelated changes be pulled out

Description

Changes the default load order for aliases from 150 to 750, and updates all the tests.

This addresses #825, but doesn't resolve.

Motivation and Context

This is an ongoing issue due to the fact that we create so many aliases, combined with that aliases are captured by functions. Loading late at least reduces the likelihood the aliases will be unexpectedly be captured by function definitions.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant