-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for explainable
for model with continuous variables
#565
base: master
Are you sure you want to change the base?
Conversation
Thanks for taking this on @rfl-urbaniak and @PoorvaGarg ! It's great progress towards a very interesting combination of previously very disconnected ideas. I have a fair number of comments because it's pretty long and detailed, but overall I really like where this is going. I've made a small number of editorial changes to the notebook itself, which can be found in #573 . The more substantive requests for changes are better left to discussion and then collaborative revision. With that, here are my comments: Main Feedback:
Detailed Feedback: “Now we incorporate the Bayesian SIR model into a larger model that includes the effect of two different policies, lockdown and masking, where each can be implemented with Why do we need the I separated the “Trajectories and overshoot distribution in the but-for analysis” requests:
Why do we need Can we add some citations justifying “degree of responsibility”? “The reader might have the impression that the numbers are relatively low: …” Could we suggest a more intuitive description of what these probabilities are? If they shouldn’t be interpreted as any conceptually meaningful probabilities, then we should emphasize that explicitly or consider removing. “Counterfactual - necessity world” figure (and all following similar plots) requests:
“Filter for the relevant context” -> Something about conditioning on the context nodes. I don’t like the word “filter” here. “Comparing how necessity interventions for the two antecedents affect the overshoot” I don’t know what this means. I think the terminology of “necessity world” and “sufficiency world” is a little confusing. Is there a way we could reuse the mathematical notation introduced earlier to denote which counterfactual world we’re considering at any given point in the narrative? Heatmap suggestions/questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment for requested changes.
* edit intro * progress * remove plate and more edits
This pull request adds a tutorial for the module
explainable
in the context of a model with continuous variables and dynamical systems.