Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Add the implementation for the Bastian Javacord Audio branch. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChosenQuill
Copy link

Without implementing the audio branch, you don't have access to the javacord audio api. Putting this in the readme may help some pour soul trying to figure out why they can't access the javacord api.

@Bastian
Copy link
Owner

Bastian commented Apr 22, 2019

Thank you for your PR. :)

It should not be necessary to add my Javacord fork as a dependency, as it should be inherited from the Lavaplayer-Wrapper as a transitive dependency. Take a look at Moskau-Bot's Gradle file: https://github.com/Bastian/Moskau-Bot/blob/master/build.gradle
It's just important that you don't add the "normal" Javacord dependency but only the Lavaplayer-Wrapper.

@ChosenQuill
Copy link
Author

Hmm that is interesting. Because when I was testing it, I had issues as implementing your lavaplayer wrapper did not automatically inherit the javacord audio fork. This could be a potential issue as I thought the non auto import was intentional.
When importing only the lavaplayer wrapper, only access was given to the lava player wrapper itself.
import ex
another import ex

Only through importing the javacord audio branch (the same as the one you used in your gradle build) was I able to access all javacord functionality.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants