Skip to content

Commit

Permalink
Properly define version to avoid complaints from CI/CD.
Browse files Browse the repository at this point in the history
  • Loading branch information
CptMoore committed Dec 24, 2024
1 parent 006c223 commit be295e8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
5 changes: 5 additions & 0 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
<PackageVersion Include="GitVersion.MsBuild" Version="5.12.0" />
<!-- remove Mono.Cecil reference in ModTek.Preloader.csproj if Mono.Cecil gets updated transivitely via HarmonyX -->
<PackageVersion Include="HarmonyX" Version="2.13.0" />
<!-- there seems to be an issue between Mono Cecil 0.11.5 in.NET Framework (ModTek) and .NET Standard (RTPerfFix) 0.11.4 (version pinned by HarmonyX) -->
<!-- Exception: Object of type 'ModTek.Injectors.AssemblyCache' cannot be converted to type 'Mono.Cecil.IAssemblyResolver'. -->
<!-- Mono Cecil 0.11.6 in .NET Framework (ModTek) and 0.11.4 in .NET Standard (RTPerfFix) seems to be ok -->
<!-- remove this once HarmonyX is updated to use a newer Mono.Cecil version (also remove PackageReference in Preloader csproj) -->
<PackageVersion Include="Mono.Cecil" Version="0.11.6" />
<PackageVersion Include="PolySharp" Version="1.15.0" />
</ItemGroup>
</Project>
7 changes: 2 additions & 5 deletions ModTek.Preloader/ModTek.Preloader.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,8 @@

<ItemGroup>
<PackageReference Include="HarmonyX" />
<!-- there seems to be an issue between Mono Cecil 0.11.5 in.NET Framework (ModTek) and .NET Standard (RTPerfFix) 0.11.4 (version pinned by HarmonyX) -->
<!-- Exception: Object of type 'ModTek.Injectors.AssemblyCache' cannot be converted to type 'Mono.Cecil.IAssemblyResolver'. -->
<!-- Mono Cecil 0.11.6 in .NET Framework (ModTek) and 0.11.4 in .NET Standard (RTPerfFix) seems to be ok -->
<!-- remove this once HarmonyX is updated to use a newer Mono.Cecil version -->
<PackageReference Include="Mono.Cecil" Version="0.11.6" />
<!-- TODO check if can be removed, see Directory.Packages.props -->
<PackageReference Include="Mono.Cecil" />
<Reference Include="Newtonsoft.Json">
<Private>False</Private>
</Reference>
Expand Down

0 comments on commit be295e8

Please sign in to comment.