Consolidating network fidelity work #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…highway_assign.py line 139)
|
I am merging this PR, the code review and testing will be done as part of the network-fidelity PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What existing problem does the pull request solve and why should we include it?
Consolidating Sijia's and Lachie's branches, before merging them into develop.
What is the testing plan?
Demonstrate the code is solid by discussing how results are verified and covered by tests
Code formatting
Code should be PEP8 compliant before merging by running a package like
blackApplicable Issues
See this main PR: #158