Drop support for Python < 2.6 on the server #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderS
force-pushed
the
drop-legacy-python-support
branch
from
b32009e
to
c6222de
Compare
solj
reviewed
Aug 17, 2017
| @@ -46,6 +46,8 @@ backwards-incompatible user-facing changes | |||
| your queries default to the class names and the Ldap plugin expires | |||
| the metadata caches if the config file changes. | |||
|
|
|||
| * Droped support for Python 2.5 or below on the bcfg2 server. | |||
|
|
|||
There was a problem hiding this comment.
Perhaps we should create release notes for pre3 (or rc1, not sure) and add this there.
There was a problem hiding this comment.
Should rc1 release note contain all changes since 1.3.x?
There was a problem hiding this comment.
@AlexanderS Hmm, that's a good question. I think you may be right that rc1 should contain all changes. Especially since we haven't released something in a while.
|
Just a quick note: Because we have now at least 2.6 on the server we could use something like that: to deal with the Python3 incompatibility. |
AlexanderS
force-pushed
the
drop-legacy-python-support
branch
2 times, most recently
from
fdeaa26
to
6f412c2
Compare
We now require Python 2.6 on the server and can use PEP 341 (Unified try/except/finally).
AlexanderS
force-pushed
the
drop-legacy-python-support
branch
from
6f412c2
to
af72350
Compare
The server does not support Python < 2.6 anymore, so we do not need to (and cannot) check the server tools with the older python versions.
|
@AlexanderS I think we just need to exclude the python2.4 travis tests to get the check to succeed here. |
Before the "error only" tests of the scripts in the sbin/ directory ignored the list of files that should not checked at all.
|
I fixed the testsuite. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the support for Python < 2.6 on the server. I removed some compat stuff and used the native variants on the server for compat stuff, that is still required for the client code.
Most stuff in
Bcfg2.Compatis for Python 3 compatibility now. We could consider to use https://pypi.python.org/pypi/six and drop our own Python 3 compat stuff. I think it provides all the Python 3 compatibility we need.