Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: all features added #11

Open
wants to merge 49 commits into
base: dappnet
Choose a base branch
from
Open

feat: all features added #11

wants to merge 49 commits into from

Conversation

JenkJS
Copy link
Collaborator

@JenkJS JenkJS commented Mar 2, 2023

No description provided.

@JenkJS JenkJS requested a review from razoorka March 2, 2023 07:33
},
[data, poolsList],
);
useMemo(() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make no sense

if (favorites.length === 0) {
handleSort('all');
}
}, [favorites.length]);

useMemo(() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make no sense

<HeaderWrapperSort>
<Sort>
<WrapperSelect>
<ReactSelect
options={options}
isClearable
onChange={(e) => onFilter(e)}
defaultValue={() => localFiltered}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the value is the function?)

@@ -129,6 +149,7 @@ export const PoolsList = () => {
key={el.value}
active={currentFilter === el.value}
onClick={() => handleSort(el.value)}
disabled={!!(el.value === 'fav' && !favorites.length)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move check to variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants