Closes #3219: Optimize old Parquet srting read code #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcdonald3
force-pushed
the
string-reg-opt
branch
from
c63837c to
73c4268
Compare
bmcdonald3
force-pushed
the
string-reg-opt
branch
3 times, most recently
from
6881f7f to
884b94e
Compare
|
@stress-tess I think this PR is finally ready to go. A similar pattern to this can be applied everywhere where we've been rolling back the batch optimization in favor of the single reads to accomodate null values. I am still gathering some performance numbers on various machines, but if we could get this into the release this week, that'd be great. |
bmcdonald3
force-pushed
the
string-reg-opt
branch
from
2692c6c to
e73043e
Compare
|
This will pass CI after #3312 is merged (and we rebase on top of it) |
bmcdonald3
force-pushed
the
string-reg-opt
branch
from
3abef5b to
290f1e3
Compare
ajpotts
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing more results gathered on different machines showing mixed results for the new Parquet string optimization, we have decided to make some changes and go back towards a simpler optimization that we are more confident in across the board optimizations, though, they may be more minor than the "best case" with the optimized version, but we shouldn't be seeing any cases get worse with this approach, which seems preferable.