3917 copy function to match numpy #3925
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
3917_copy_function_to_match_numpy
branch
2 times, most recently
from
2297a4c to
9b2eee0
Compare
ajpotts
force-pushed
the
3917_copy_function_to_match_numpy
branch
2 times, most recently
from
c0067d1 to
c990e15
Compare
ajpotts
force-pushed
the
3917_copy_function_to_match_numpy
branch
from
c990e15 to
cb7d2ec
Compare
ajpotts
commented
Dec 10, 2024
|
|
||
| if isinstance(a, Strings): | ||
| cpy = a[:] | ||
| return cpy |
There was a problem hiding this comment.
Call Strings.copy()
ajpotts
commented
Dec 10, 2024
| if copy is False: | ||
| if isinstance(a, (Strings, pdarray)): | ||
| return a | ||
|
|
ajpotts
commented
Dec 10, 2024
| @@ -192,6 +199,7 @@ def array( | |||
| to create the Strings object and the two corresponding pdarrays for string | |||
| bytes and offsets, respectively. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Add more comments about why we are changing from numpy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a copy function to match numpy:
https://numpy.org/doc/2.1/reference/generated/numpy.copy.html
Also modifies the
arrayfunction to operate onStrings, and to have a copy argument. Whencopy=False, the original array will be returned, rather than a copy, if possible.Closes #3917 copy function to match numpy