Skip to content

Commit

Permalink
do not test deployed packages
Browse files Browse the repository at this point in the history
Disable testing after deployment to TestPyPi/PyPi because tests
require a working GROMACS installation. GROMACS binary packages
are not available on PyPi, which are the only packages that
the action is able to install.

MAKE SURE TO MANUALLY TEST A TestPyPi PACKAGE BEFORE RELEASE.
  • Loading branch information
orbeckst committed Sep 19, 2024
1 parent d6bbcfd commit a628e2f
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
if: |
github.repository == 'Becksteinlab/GromacsWrapper' &&
(github.event_name == 'push' && startsWith(github.ref, 'refs/tags/'))
name: "TestPyPi: Build, upload, and test pure Python wheels"
name: "TestPyPi: Build and upload pure Python wheels"
runs-on: ubuntu-latest

steps:
Expand All @@ -31,7 +31,8 @@ jobs:
test_submission: true
package_name: 'GromacsWrapper'
module_name: 'gromacs'

tests: false

pypi_push:
environment:
name: PyPi
Expand All @@ -41,7 +42,7 @@ jobs:
if: |
github.repository == 'Becksteinlab/GromacsWrapper' &&
(github.event_name == 'release' && github.event.action == 'published')
name: "PyPi: Build, upload, and test pure Python wheels"
name: "PyPi: Build and upload pure Python wheels"
runs-on: ubuntu-latest

steps:
Expand All @@ -50,6 +51,7 @@ jobs:
- name: pypi_deploy
uses: MDAnalysis/pypi-deployment@main
if: github.event_name == 'release' && github.event.action == 'published'
with:
with:
package_name: 'GromacsWrapper'
module_name: 'gromacs'
tests: false

0 comments on commit a628e2f

Please sign in to comment.