-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use importlib.resources instead of pkg_resources #284
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
- Coverage 69.20% 0.00% -69.21%
==========================================
Files 22 22
Lines 3959 3954 -5
Branches 717 0 -717
==========================================
- Hits 2740 0 -2740
- Misses 1038 3954 +2916
+ Partials 181 0 -181 ☔ View full report in Codecov by Sentry. |
3.9 - 3.11 runners fail with errors such as
Python 3.12 works. |
fdf47d2
to
edbc90d
Compare
In 3.12, we can use a module instead of a package as an anchor for importlib.resources.files
|
- fix #282 - config.templates - tests.datafiles - note: write resources.file() for python 3.9-3.11 (3.12 is nicer)
0c4bafc
to
03d3010
Compare
- ignore some warnings in pytest - check for some gromacs.UsageWarning explicitly
fix #282