fix "DeprecationWarning: invalid escape sequence '\s'" #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage 69.20% 69.20%
=======================================
Files 22 22
Lines 3959 3959
Branches 717 717
=======================================
Hits 2740 2740
Misses 1038 1038
Partials 181 181 ☔ View full report in Codecov by Sentry. |
orbeckst
commented
Jun 16, 2024
gromacs/core.py
Outdated
| doc_pattern = """.*?(?P<DOCS>DESCRIPTION.*)""" | ||
| gmxfatal_pattern = """----+\n # ---- decorator line | ||
| doc_pattern = r""".*?(?P<DOCS>DESCRIPTION.*)""" | ||
| gmxfatal_pattern = r"""----+\n # ---- decorator line |
There was a problem hiding this comment.
I am not 100% sure that the newline is actually captured by the raw-string expression.
Ought to check if there's actually a test for that.
There was a problem hiding this comment.
Now there is.
(Of course it hadn't worked ... untested code is broken code!)
- can now recognize newer gromacs messages - added quick tests for the three fail modes of GromacsCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #285