split timeout into read and write timeouts #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes you need to have a different timeouts for reads and writes. As an example when you might need higher timeout for long processing consumers and small write timeout for failing fast producers
|
Anything I can help here? |
Oliboy50
approved these changes
Apr 2, 2018
There was a problem hiding this comment.
LGTM (thanks and sorry for keeping you waiting)
according to the amqp extension, the constructor accepts these params:
/* {{{ proto AMQPConnection::__construct([array optional])
* The array can contain 'host', 'port', 'login', 'password', 'vhost', 'read_timeout', 'write_timeout', 'connect_timeout' and 'timeout' (deprecated) indexes
*/so I wonder why did we set the heartbeat argument in the first place? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you need to have a different timeouts for reads and writes. As an example when you might need higher timeout for long processing consumers and small write timeout for failing fast producers
I have kept backwards compatibility. Documentation update is actually missing, should I?