Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Fixes Shake() Proc, adds charging for mobs, Lava/Artic Lobstrositys. #12137

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Therealdoooc213
Copy link
Contributor

@Therealdoooc213 Therealdoooc213 commented Jan 9, 2025

About The Pull Request

Ports:

Adds a new lavaland fauna, the lava lobstrosity!
This new mob will charge at you when threatened, dealing 19 brute damage per hit (6 hits to crit unarmored).
It has a extremely obvious tell for its charges, visibly shaking before charging directly at you.

(Note: I decided to keep Artic lobtrosities, as mappers might want to use them.)

Why It's Good For The Game

New fauna is always great for miners, providing a new and interesting challenge for them to take on.

Testing Photographs and Procedure

Screenshots&Videos

Shown in video: The lobstrositys charge working, and Shake() not being broken.)

2025-01-09.10-19-21.mp4

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ArcaneMusic, Kryson, Jacquerel, Therealdoooc213
add: Lobstrosities! Mean lobsters that'll charge at you (Found on lavaland)
fix: Shake() now works.
code: Mobs can now charge.
/:cl:

@Therealdoooc213
Copy link
Contributor Author

mfw

@Therealdoooc213 Therealdoooc213 marked this pull request as draft January 9, 2025 03:13
@Therealdoooc213
Copy link
Contributor Author

2025-01-09.12-28-41.mp4

Minor adjustment, Lobstrosities will do their tell and charge at the same time.

@Therealdoooc213 Therealdoooc213 marked this pull request as ready for review January 9, 2025 05:04
@Fronsis
Copy link

Fronsis commented Jan 9, 2025

Finally.. lobster people are real in 2025

@PerishedFraud
Copy link
Contributor

PerishedFraud commented Jan 11, 2025

actual mining content holy shit. I hope they drop some ore on death. Doesn't the "do their charge and tell at the same time" completely remove the point of the tell though, lol.

@Tsar-Salat
Copy link
Contributor

why does he react so slow smh

@Therealdoooc213
Copy link
Contributor Author

why does he react so slow smh

Because miner players are noobs

@Therealdoooc213
Copy link
Contributor Author

Doesn't the "do their charge and tell at the same time" completely remove the point of the tell though, lol.

When I was personally playing around with the lobstrositys, I felt like the tell made it 'too easy' to fight. But completely removing the tell would've made it weird if it just... walked towards you super fast, so i kept it.

Copy link
Contributor

@DrDuckedGoose DrDuckedGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start with this

code/modules/mob/living/simple_animal/hostile/hostile.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/hostile/hostile.dm Outdated Show resolved Hide resolved
code/modules/mob/living/simple_animal/hostile/hostile.dm Outdated Show resolved Hide resolved
@DrDuckedGoose
Copy link
Contributor

It's too late now but-
In the future, do you reckon you could make the fix & feature separate PRs?
What you can do is, make a fix branch, then base the feature branch off that branch / PR. This means we can merge the fix, but not the feature, if we don't like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants