Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pref for admin login #12198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tsar-Salat
Copy link
Contributor

About The Pull Request

This removes the pref and code associated with the preference that lets an admin change whether their arrival is announced or not in the admin log.

Why It's Good For The Game

There really is no reason for admins not to be announced in the admin log.

Ive had admins join and I've missed them for a long time because I forgot to check staffwho midround. Its even weirder that this preference is default to off.

I ask for other admins opinions and didn't receive any dissenting opinions.

Testing Photographs and Procedure

Screenshots&Videos

Screenshot 2025-01-26 113146

Changelog

🆑
admin: removed admin preference to announce login. Admin arrivals will always be announced in admin logs.
/:cl:

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this as a preference you can disable for yourself really doesn't make any sense

Copy link
Member

@itsmeow itsmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the typescript definition for it in tgui

@github-actions github-actions bot added the TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 label Jan 27, 2025
@Tsar-Salat Tsar-Salat requested a review from itsmeow January 27, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants