Change histogram import #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Histogram has been removed in `scipy` but is available in `numpy` The requirement `numpy>=1.15.2` should cover the import.
`chemnet_model_filename` changed in FCD v1.2 as it was ported to pytorch. The functionality in `_load_chemnet` has since been copied to FCD and could be replaced with `fcd.load_ref_model(model_path=None)` down the road.
|
i was going to request this as well. tested on my end and works |
Excuse me, I met the questions when conducting 'python -m guacamol.data.get_data -o ./' as follows: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Histogram has been removed in
scipybut is available innumpyThe requirementnumpy>=1.15.2covers the import.