feat: toggle warp command #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, I was thinking if there is a way to directly convert it but there isn't because of the way it was structured. This *ISN'T* the best way around things but if someone can find a better way around it, be my guest.
note `line 294` of `warp.java`, I am unsure what this does and whether it should be `getWarpLocation` or not. I will leave it for the time being.
tastybento
reviewed
Jun 21, 2024
- getToggleCommand is linked to toggleWarpCommand instead of hardcoded - warpSigns is now null and not empty
tastybento
approved these changes
Jun 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6
Probably needs some checking around the code. I couldn't figure out a great way on how to deal with the storage of
warpDataand changing it completely tonewWarpDataas you'll see in the code.The tests for the new commands and such are required to be done but I've tested the following in a live server to make sure it works:
Map<UUID, PlayerWarp>from aMap<UUID, Location>stored in database (for some reason, it doesn't convert tonewWarpDatauntil some edits or makes a new warp which is confusing)If there is any suggestions, please let me know.