Fix NullPointerException when native class is not present #198
Conversation
| @@ -41,7 +41,7 @@ public static T Get<T>(IntPtr ptr) | |||
| unsafe | |||
| { | |||
| var nativeClassStruct = UnityVersionHandler.Wrap((Il2CppClass*)Il2CppClassPointerStore<T>.NativeClassPtr); | |||
| if (!nativeClassStruct.HasFinalize) | |||
| if (!nativeClassStruct?.HasFinalize is true) | |||
There was a problem hiding this comment.
I think the ! shouldn't be there.
There was a problem hiding this comment.
!null is not true. if we get !false it is true like expected. Inversion operates only on bool values.
In this case:
- nativeClassStruct checked on null. If it is null - returns Nullable else gets property.
- Nullable cannot be inversed by operator
!. If property is present - it will be inversed - Comparison with true
But if you mean that the condition itself is false to begin with, then I'm not sure what that field points to.
There was a problem hiding this comment.
It seems to indicate the presence of a destructor. And if there is no destructor, then we add a reference to the object in GC to finalize it
There was a problem hiding this comment.
Oh, I initially meant is false
There was a problem hiding this comment.
if native class has finalize, we add it to GC, right?
There was a problem hiding this comment.
if (!nativeClassStruct.HasFinalize) should be changed to one of the following, and I'm not sure which:
if (nativeClassStruct?.HasFinalize is false)if (nativeClassStruct?.HasFinalize is false or null)
There was a problem hiding this comment.
The second one looks more correct. If I understood the logic correctly - if native class does not have destructor, we add a reference in GC. When native class pointer is null we also need to keep track of the created object. The problem may arise if a class without a pointer has a destructor
There was a problem hiding this comment.
@js6pak Which do you think it should be, or how would you suggest we address the problem?
A part of this pull request.
Required more in-depth review. Probably unstripped classes do not have a pointer to the native class in Il2CppClassPointerStore context. With UnityEngine.AssetBundleModule.AssetBundle works fine, but i'm not sure about GC Finalize.