Show location of error in ActionView template error #463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #461, fixes #462.
Previous to Rails 5.1, when an error was raised in a template, it included the location within the template in the backtrace. As of 5.1, the exception was replaced with an
ActionView::Template::Error
which providesfile_name
andline_number
but does not include those in the backtrace. It does provide acause
which contains the real error and correct backtrace, but as of Better Errors 2.7.0 (#459) we stopped showing only the "cause" of an error. (And in the future we want to add navigation within the chain of error causes, see #464.)SyntaxError
andHaml::SyntaxError
were handled specially by Better Errors, finding the filename and line number within the exception message and synthesizing a backtrace item based on those. The workaround forActionView::Template::Error
looks exactly like those.The result is that the topmost backtrace item will be the location of the error within the template.