Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing more methods on wtransport::Connection from underlying quinn::Connection object #26

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

JustSomeDude301
Copy link
Contributor

#25

Copy link
Owner

@BiagioFesta BiagioFesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

LGTM, just a few nits on doc

wtransport/src/connection.rs Outdated Show resolved Hide resolved
wtransport/src/connection.rs Outdated Show resolved Hide resolved
wtransport/src/connection.rs Outdated Show resolved Hide resolved
@BiagioFesta BiagioFesta self-assigned this Jul 11, 2023
@BiagioFesta BiagioFesta added the enhancement New feature or request label Jul 11, 2023
@BiagioFesta
Copy link
Owner

I rebased your PR and squashed in one single commit.

I merged the commit on master, but GitHub is not able to see the merge because I fix a nit. Can you try to rebase the branch on your fork?

@JustSomeDude301
Copy link
Contributor Author

JustSomeDude301 commented Jul 14, 2023

Rebased, please do not hesitate to let me know if you need me to do anything else in any future issues. Thank you again for your suggestions on my connection map and for your work on this library. If you have a private channel (like a discord server) I'd be more than happy to share more about my use case

@BiagioFesta BiagioFesta merged commit b31553f into BiagioFesta:master Jul 14, 2023
1 check passed
@BiagioFesta
Copy link
Owner

I am not really into Discord, but I think it might be a good idea to start a project related chat-community.

https://wtransport.zulipchat.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants