Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Controllers Page #177

Merged
merged 17 commits into from
Nov 19, 2024
Merged

Added Controllers Page #177

merged 17 commits into from
Nov 19, 2024

Conversation

Gold872
Copy link
Member

@Gold872 Gold872 commented Oct 29, 2024

image

Useful to debugging issues with the controller itself, the indicators on top of the image automatically scale with the window

@Gold872 Gold872 requested a review from Levi-Lesches as a code owner October 29, 2024 22:46
Levi-Lesches
Levi-Lesches previously approved these changes Oct 30, 2024
Copy link
Member

@Levi-Lesches Levi-Lesches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a nasty bug in ReusableReactiveWidget that wasn't letting you switch controllers properly. Had to do with State.didUpdateWidget. Should be good to merge now though. I also added a vibrate button and changed the color to a slightly more palatable yellow

@Gold872
Copy link
Member Author

Gold872 commented Nov 19, 2024

Forgot about this PR, what's the reason for changing the color to blue? I think yellow stands out more

@Levi-Lesches
Copy link
Member

I was just touching this up actually! Yellow didn't really stand out more, blue had better contrast on light and mobile, and is more consistent with our other pages and graphs, and it's kind of easier on the eyes. Will merge in a moment though, I just can't seem to get this vibrate button working

@Levi-Lesches Levi-Lesches merged commit 14066ef into main Nov 19, 2024
1 check passed
@Levi-Lesches Levi-Lesches deleted the controllers-page branch November 19, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants