Decode nocheck #281
Merged
Decode nocheck #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 90.96% 91.01% +0.04%
==========================================
Files 31 31
Lines 2402 2392 -10
==========================================
- Hits 2185 2177 -8
+ Misses 217 215 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Relax the requirement of `Alphabet`, such that it is no longer necessary to check for a valid encoding in `decode`. This implies that storing invalid data in a `BioSequence` is disallowed, but it speeds up `getindex(::BioSequence)`, which is critical.
jakobnissen
force-pushed
the
decode_nocheck
branch
from
c880438
to
2d089a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the requirement of
Alphabet, such that it is no longer necessary tocheck for a valid encoding in
decode.This implies that storing invalid data in a
BioSequenceis disallowed, but itspeeds up
getindex(::BioSequence), which is critical.