Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #283

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Fix tests #283

merged 2 commits into from
Aug 21, 2023

Conversation

jakobnissen
Copy link
Member

See commit messages for more.

Turns out Julia is allowed to change the types of exceptions (#50633), which
I'm pretty miffed about.
Work around this to prevent tests from failing in Julia 1.11 due to Julia
PR #49322.
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (1ccb602) 91.21% compared to head (a9b8e59) 91.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   91.21%   91.26%   +0.04%     
==========================================
  Files          31       31              
  Lines        2403     2403              
==========================================
+ Hits         2192     2193       +1     
+ Misses        211      210       -1     
Flag Coverage Δ
unittests 91.26% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakobnissen jakobnissen merged commit 2f9ff46 into BioJulia:master Aug 21, 2023
27 of 28 checks passed
@jakobnissen jakobnissen deleted the fixtests branch August 21, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant