Release 0.3.1 #57
Merged
Release 0.3.1 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than keep a copy of the BioAlignments cigar constructor embedded in this function, have it call the existing constructor. There may be performance implications for using `cigar` instead of `cigar_rle`, but having a second copy of the constructor here is an antipattern if I've ever seen one, so prioritise stable code over performant code.
MillironX
force-pushed
the
release/0.3.1
branch
from
21815d4
to
fe83a74
Compare
CiaranOMara
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for review of the v0.3.1 release, which includes
Basically makes it so the latest version of XAM.jl in the registry is compatible with the latest version of BioAlignments.jl in the registry.