Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a binomial name field to label maker GUI, allows full name styling #348

Open
wants to merge 1 commit into
base: mickley-label
Choose a base branch
from

Conversation

mickley
Copy link

@mickley mickley commented Dec 15, 2022

Previously, the visual interface had fields for scientific name, infraspecific epithet, taxon rank, scientific name authorship, and parent authorship, and would expose parent authorship to the labelmaker when the Print species authors for infraspecific taxa option was checked. However, this did not work in a case where both the parent authorship and the infrataxon authorship should be displayed, for example:
Symphoricarpos albus (L.) S.F. Blake var. laevigatus (Fernald) S.F. Blake.

In this example, since the scientific name was Symphoricarpos albus var. laevigatus, there was no way to insert the parent author correctly before the taxon rank. This format is a common one for plant labels.

This fix enables a new field Binomial Name to the label maker GUI that is just the genus and specific epithet, without the infrataxon. That allows each aspect of the name to be included in the proper order, and to be themed separately, e.g., the binomial name and the infraspecific epithet are typically italicized (and sometimes bolded as above), while the taxon rank and the authorships are not.

Some additional quirks

  • For taxonomic names not in the thesaurus, there are no fields passed to the label maker by default for binomial name, taxon rank, and infraspecific epithet. The code detects this case and attempts to parse out those sections from the scientific name in the occurrence record (for ssp., var., f., and nothossp.).
  • For autonyms (where the infraspecific epithet matches the species epithet), the infraspecific author is typically not included, because it is the same as the species author by definition. The code detects this as well, and removes the infraspecific author if it is specified.

…me to be styled

Previously, the visual interface had fields for scientific name, infraspecific epithet, taxon rank, scientific name authorship, and parent authorship, and would expose parent authorship to the labelmaker when the `Print species authors for infraspecific taxa` option was checked. However, this did not work in a case where both the parent authorship and the infrataxon authorship should be displayed, for example: `**Symphoricarpos albus** (L.) S.F. Blake var. **laevigatus** (Fernald) S.F. Blake`. In this example, since the scientific name was `**Symphoricarpos albus** var. **laevigatus**`, there was no way to insert the parent author correctly. This format is a common one for plant labels.

This fix enables a new field `Binomial Name` to the label maker GUI that is just the genus and species, without the infrataxon (represented internally as speciesname). That allows each aspect of the name to be included in the proper order, and to be themed separately, e.g., the binomial name and the infraspecific epithet are typically italicized (and sometimes bolded), while the taxon rank and the authorships are not.

One issue is that for taxonomic names not in the thesaurus, there are no fields by default for binomial name, taxon rank, and infraspecific epithet. The code detects this case and attemps to parse out those sections from the scientific name in the occurrence record.
Furthermore, for autonyms (where the infraspecific epithet matches the species epithet), the infaspecific author is typically not included, because it is the same as the species author by definition. The code detects this as well, and removes the infraspecific author if it is specified.
@mickley
Copy link
Author

mickley commented Dec 15, 2022

Thanks @arbolitoloco for the tips.

And here are a few screenshots.

Label maker GUI:
Screen Shot 2022-12-15 at 1 18 10 PM

Name of a species with an infrataxon, showing both parent author and infrataxon author:
Screen Shot 2022-12-15 at 1 17 13 PM

Name of an autonym showing only the species author (since the infrataxon author is the same by definition):
Screen Shot 2022-12-15 at 1 17 39 PM

@arbolitoloco arbolitoloco self-requested a review December 16, 2022 16:22
@arbolitoloco arbolitoloco changed the base branch from master to Development December 16, 2022 16:51
@arbolitoloco arbolitoloco changed the base branch from Development to master December 16, 2022 16:54
@arbolitoloco arbolitoloco changed the base branch from master to mickley-label December 16, 2022 16:56
kyule pushed a commit that referenced this pull request Nov 7, 2023
Merge BioKIC/Symbiota developments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant