Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smp case #777

Merged
merged 9 commits into from
Jun 28, 2023
Merged

Add smp case #777

merged 9 commits into from
Jun 28, 2023

Conversation

ljgarcia
Copy link
Contributor

This PR builds on top of the create_ml_group PR and:

  • Update tools group page adding the SMP case
  • Creates pages of related people

@ljgarcia ljgarcia marked this pull request as draft June 25, 2023 12:15
@ljgarcia
Copy link
Contributor Author

@fpsom please have a look to the text about SMPs, thanks

unode
unode reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@unode unode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2 cents

pages/_groups/MachineLearning.md Outdated Show resolved Hide resolved
pages/_groups/Tools.md Outdated Show resolved Hide resolved
@ljgarcia ljgarcia marked this pull request as ready for review June 27, 2023 14:02
gtsueng
gtsueng requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@gtsueng gtsueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "(SMPs)" to line 24 of tools.md to make it explicit that smps referenced in line 74 refer to Software Management Plans

albangaignard
albangaignard approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@albangaignard albangaignard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@ljgarcia ljgarcia requested a review from gtsueng June 28, 2023 08:43
@ljgarcia ljgarcia merged commit b5b6026 into master Jun 28, 2023
@ljgarcia ljgarcia deleted the add_smp_case branch June 28, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpsom fpsom fpsom left review comments

@unode unode unode left review comments

@albangaignard albangaignard albangaignard approved these changes

@gtsueng gtsueng gtsueng approved these changes

@ivanmicetic ivanmicetic Awaiting requested review from ivanmicetic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ljgarcia @unode @fpsom @gtsueng @albangaignard