Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Pharos resource to live deploys #787

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add new Pharos resource to live deploys #787

merged 2 commits into from
Oct 26, 2023

Conversation

ljgarcia
Copy link
Contributor

@ljgarcia ljgarcia commented Sep 8, 2023 •
edited
Loading

Still in draft until pages go live in October.2023

@ljgarcia ljgarcia marked this pull request as draft September 8, 2023 15:41
@ljgarcia ljgarcia marked this pull request as ready for review October 25, 2023 19:12
@albangaignard
Copy link
Contributor

Thanks @ljgarcia, I tried to check the embedded metadata but can't find any instance of Protein: https://fair-checker.france-bioinformatique.fr/api/inspect/get_rdf_metadata?url=https://pharos.nih.gov/targets/CAMK2A.

Am I testing the right URL ? (https://pharos.nih.gov/targets/CAMK2A)

@albangaignard
Copy link
Contributor

Ok, after checking, the problem seems to be on the FAIR-Checker side.
I need to investigate, but everything is ok for the Live Deploys update.

albangaignard
albangaignard approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@albangaignard albangaignard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine on my working copy

@albangaignard albangaignard merged commit e4aaef8 into master Oct 26, 2023
1 check passed
@albangaignard albangaignard deleted the new_resource_pharos branch October 26, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albangaignard albangaignard albangaignard approved these changes

@ivanmicetic ivanmicetic Awaiting requested review from ivanmicetic

@nsjuty nsjuty Awaiting requested review from nsjuty

Assignees
No one assigned
Labels
Live Deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljgarcia @albangaignard @egonw