Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency check #113

Open
lshep opened this issue Nov 3, 2020 · 5 comments
Open

Add dependency check #113

lshep opened this issue Nov 3, 2020 · 5 comments

Comments

@lshep
Copy link
Contributor

lshep commented Nov 3, 2020

warnings if too many dependencies

@LiNk-NY
Copy link
Contributor

LiNk-NY commented Nov 16, 2022

IIRC this is handled by R CMD check when there are multiple packages in the Depends field.
Should BiocCheck do more than what R CMD check provides?
If so, the guidelines should be updated first if we want to enforce that a package cannot depend on more than X # of packages.

Update: It seems this shows up when using the --as-cran flag:
R CMD check --as-cran uncoverappLib:

N  checking package dependencies (4.9s)
   Imports includes 25 non-default packages.
   Importing from so many packages makes the package vulnerable to any of
   them becoming unavailable.  Move as many as possible to Suggests and
   use conditionally.

@llrs
Copy link
Contributor

llrs commented Oct 28, 2024

Perhaps this is easily done here, but it could also be done via [_R_CHECK_EXCESSIVE_IMPORTS_](https://cran.r-project.org/doc/manuals/r-devel/R-ints.html#index-_005fR_005fCHECK_005fEXCESSIVE_005fIMPORTS_005f) = 20 on the package checker

@Bioconductor Bioconductor deleted a comment from llrs Oct 28, 2024
@LiNk-NY
Copy link
Contributor

LiNk-NY commented Oct 28, 2024

Thanks Lluís!
I will check with the team about adding it to the BBS. It seems reasonable.
PS. I deleted the duplicate comment.

@lshep
Copy link
Contributor Author

lshep commented Oct 29, 2024

Added to SPB - Bioconductor/packagebuilder@97030b5 I'll activate it when I set up the SPB on devel post release

@llrs
Copy link
Contributor

llrs commented Oct 29, 2024

Yeh, sorry for the formatting and duplicate message. I was using a flaky internet connection. Glad this was added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants