-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One test fails on PPC: Error in checkEqualsNumeric(9, .BiocCheck$getNum("warning")): Mean relative difference: 0.1111111 #188
Comments
Hi @barracuda156 |
@LiNk-NY Sorry for a delay. The error is still there with 3.19. And, well, I do not particularly understand what is it doing:
|
@barracuda156 I cannot reproduce this either; are you sure you have the latest version of BiocCheck? |
@lshep I do. Just to be clear, has anyone tested it on any OS on |
Yes, it is tested on Linux as noted at https://bioconductor.org/checkResults/release/bioc-LATEST/BiocCheck/ I think the issue concerns the 32-bit character of your OS. The test could be softened for that context. |
@vjcitn I think on that page all tested archs are 64-bit? If the error is due to bitness, then it is of course desirable to have it fixed. (On the other hand if everything works fine on |
We don't have a 32-bit PPC. I am trying to recall the context of your testing -- you are repackaging, right? We want to help you as much as possible but without access to the platform it is hard. Can you create a PR that passes on 32-bit ppc but is innocuous for other platforms? |
This should be possible via Qemu and alike. You do not need a literally 32-bit cpu.
We provide packages in Macports for macOS users. CRAN has a rather abysmal macOS support :)
Possibly, if someone could help me with pointing out at what is likely to be failing specifically in the source. |
Thanks for taking a look. The error comes from the unit test at : BiocCheck/inst/unitTests/test_BiocCheck.R Lines 93 to 273 in 5f56c4b
You can run it interactively via: devtools::load_all(".")
source("inst/unitTests/test_BiocCheck.R")
library(RUnit)
test_vignettes0() |
The text was updated successfully, but these errors were encountered: