Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ update native dependencies in example app #57

Conversation

Pavel-Sulimau
Copy link
Contributor

Description of the Change

  • The iOS-related files were automatically updated when I ran the example app having Flutter 3.16.9 and Xcode 15.1.
  • I had to update the android compileSdkVersion and targetSdkVersion as otherwise the app in not runnable on Android.

Benefits

With the current state of the example app it is runnable on iOS, Android, macOS, Web.

Possible Drawbacks

I don't see any.

Verification Process

I ran the example app on iOS, Android, macOS, Web.

Applicable Issues

None.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f991e0) 94.46% compared to head (102116b) 94.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files           7        7           
  Lines         307      307           
=======================================
  Hits          290      290           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@BirjuVachhani BirjuVachhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BirjuVachhani BirjuVachhani merged commit c285fa8 into BirjuVachhani:main Feb 1, 2024
6 checks passed
@BirjuVachhani
Copy link
Owner

@Pavel-Sulimau Thanks for your contributions! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants