Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated params from Datamaxi.cex.candle.intervals() (v0.23.0) #67

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Remove deprecated params from Datamaxi.cex.candle.intervals() (v0.23.0) #67

merged 1 commit into from
Oct 29, 2024

Conversation

martinkersner
Copy link
Member

Update

Parameters (exchange and market) are now deprecated for Datamaxi.cex.candle.intervals method.

Usage

from datamaxi import Datamaxi
api_key = "YOUR_API_KEY"
maxi = Datamaxi(api_key=api_key)
# fetch supposed intervals for CEX candle data
maxi.cex.candle.intervals()

@martinkersner martinkersner self-assigned this Oct 28, 2024
nick-bisonai
nick-bisonai approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@nick-bisonai nick-bisonai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@martinkersner martinkersner merged commit c467c37 into main Oct 29, 2024
7 checks passed
@martinkersner martinkersner deleted the 10-28/feat/remove-deprecated-params branch October 29, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-bisonai nick-bisonai nick-bisonai approved these changes

@hayotbisonai hayotbisonai Awaiting requested review from hayotbisonai

Assignees

@martinkersner martinkersner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinkersner @nick-bisonai