Change substring() to use startIndex, endIndex instead of startIndex, length
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
============================================
+ Coverage 75.86% 76.30% +0.44%
- Complexity 12737 12803 +66
============================================
Files 1060 1037 -23
Lines 64353 60637 -3716
Branches 7110 7136 +26
============================================
- Hits 48821 46270 -2551
+ Misses 12891 11917 -974
+ Partials 2641 2450 -191
... and 40 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiazcy
reviewed
Oct 12, 2023
Cole-Greer
reviewed
Oct 13, 2023
Cole-Greer
approved these changes
Oct 13, 2023
...e/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java
Outdated
Show resolved
Hide resolved
kenhuuu
reviewed
Oct 13, 2023
| // to the positive index position or 0 when negative index exceeds the string length, which means an empty string | ||
| // will be returned, if it is positive and exceeds the length of the string, it is converted to the length of the | ||
| // string. | ||
| private int processEndIndex(int strLen) { |
There was a problem hiding this comment.
This is basically the same function as processStartIndex(). Consider refactoring.
kenhuuu
reviewed
Oct 13, 2023
| assertEquals("ello world", __.__("hello world").substring(1, 11).next()); | ||
| assertEquals("d", __.__("hello world").substring(10, 11).next()); | ||
| assertEquals("hello world", __.__("hello world").substring(-11, 11).next()); | ||
| assertEquals("h", __.__("hello world").substring(-11, 1).next()); |
There was a problem hiding this comment.
Missing a test for two negative numbers like (-3,-2).
xiazcy
reviewed
Oct 13, 2023
| @@ -55,11 +55,11 @@ Feature: Step - substring() | |||
| | p | | |||
| | pple | | |||
|
|
|||
There was a problem hiding this comment.
General comment, I would add some feature test cases with combinations of (pos start index, neg end index), (neg start index, pos end index), and (neg start index, neg end index).
ryn5
force-pushed
the
ryan/substring-update
branch
from
02b865b to
c87171b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.