Fix doc links and update test naming #94
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #94 +/- ##
=============================================
- Coverage 76.18% 76.16% -0.02%
+ Complexity 13109 13107 -2
=============================================
Files 1082 1083 +1
Lines 64967 64994 +27
Branches 7252 7256 +4
=============================================
+ Hits 49496 49504 +8
- Misses 12780 12791 +11
- Partials 2691 2699 +8 ☔ View full report in Codecov by Sentry. |
|
LGTM. Seems mostly like formatting changes. |
| @@ -1543,7 +1543,7 @@ Null values from the incoming traverser are not processed and remain as null whe | |||
| * For `Scope.global` or parameterless function calls, if the incoming traverser is a non-String value then an `IllegalArgumentException` will be thrown. | |||
| * For `Scope.local`, if the incoming traverser is not a string or a list of strings then an `IllegalArgumentException` will be thrown. | |||
|
|
|||
| See: link:https://github.com/apache/tinkerpop/tree/x.y.z/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ToLowerStep.java[source], | |||
| See: link:https://github.com/apache/tinkerpop/tree/x.y.z/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ToLowerGlobalStep.java[source], | |||
There was a problem hiding this comment.
We should probably add a second link for the local versions of all of these steps as well.
There was a problem hiding this comment.
Dedup only links to the global one, so I'm leaving it as the global one (since it's also the default)
There was a problem hiding this comment.
Hmm, I wrote the dedup semantics docs, I think that was an oversight on my part
| @@ -341,7 +341,7 @@ See: link:https://tinkerpop.apache.org/docs/x.y.z/reference/#dateAdd-step[dateAd | |||
| See: link:https://tinkerpop.apache.org/docs/x.y.z/reference/#dateDiff-step[dateDiff()-step] | |||
| See: link:https://issues.apache.org/jira/browse/TINKERPOP-2979[TINKERPOP-2979] | |||
|
|
|||
| ===== `datetime()` for current server time | |||
| ===== `datetime()` for Current Server Time | |||
|
|
|||
| Function `datetime()` extended to return current server time when used without argument. | |||
There was a problem hiding this comment.
Do we want to add a note that datetime() remains a script only function? Or is it best to leave that out?
xiazcy
force-pushed
the
yang/fix-doc-and-test-name
branch
from
bd83613 to
9c4022d
Compare
xiazcy
force-pushed
the
yang/fix-doc-and-test-name
branch
from
4dd0996 to
d8ddbfd
Compare
No description provided.