Allow aliased client to pass along options when submitting traversals #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryn5
changed the title
ryn5
force-pushed
the
ryan/aliased-client
branch
from
7112ebb to
9f5d222
Compare
ryn5
changed the title
vkagamlyk
reviewed
Mar 8, 2024
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/ClientWithOptionsTest.java
Outdated
Show resolved
Hide resolved
vkagamlyk
reviewed
Mar 8, 2024
gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/ClientWithOptionsTest.java
Outdated
Show resolved
Hide resolved
xiazcy
reviewed
Mar 8, 2024
| @@ -642,7 +642,7 @@ public static class AliasClusteredClient extends Client { | |||
|
|
|||
| @Override | |||
| public CompletableFuture<ResultSet> submitAsync(final Bytecode bytecode) { | |||
| return submitAsync(bytecode, RequestOptions.EMPTY); | |||
| return submitAsync(bytecode, DriverRemoteConnection.getRequestOptions(bytecode)); | |||
There was a problem hiding this comment.
I wonder if the "getRequestOptions" method should be extracted out of the DRC class now that it's also being used by the Client. It feels weird to have Client depend on DRC...
There was a problem hiding this comment.
Moved getRequestOptions to a new static subclass ClientUtil in Client.java to remove dependency.
ryn5
force-pushed
the
ryan/aliased-client
branch
from
3532289 to
def3cc4
Compare
|
VOTE+1 |
|
LGTM |
ryn5
force-pushed
the
ryan/aliased-client
branch
2 times, most recently
from
1ce60c9 to
6ee0e26
Compare
ryn5
force-pushed
the
ryan/aliased-client
branch
from
088de62 to
056aad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-3039
Changed getRequestOptions to public so that Client.submitAsync can get and pass along options.