Java client jni netty #32

Yury-Fridlyand · 2023-11-01T19:36:05Z

Simple loop benchmarking (1k iterations in nanosec):
Sync

set:    848 778 726
get NE: 771 751 075
get E:  764 494 446

Async

set:      3 134 435
get NE:   7 319 992
get E:    2 087 000

client	num_of_tasks	data_size	client_count	tps	get_non_existing_average_latency	get_existing_average_latency	set_average_latency
JNI Netty sync	100	100	1	20646.4662	0.0047044	0.004682357	0.004678821
JNI Netty sync	100	4000	1	15309.82574	0.006244713	0.006250695	0.006260645
JNI Netty sync	100	100	2	24270.17501	0.003956047	0.004007433	0.00404049
JNI Netty sync	100	4000	2	13279.11356	0.007451093	0.007315314	0.007171317
JNI Netty async	100	100	1	26854.87558	0.003518068	0.003552812	0.003543428
JNI Netty async	100	4000	1	15823.66728	0.006050023	0.006063392	0.006054922
JNI Netty async	100	100	2	31124.69244	0.003041255	0.003108889	0.003148461
JNI Netty async	100	4000	2	16343.35989	0.00580864	0.005912516	0.005825303
Lettuce	100	100	1	28248.58275	0.003453353	0.003430388	0.003475753
Lettuce	100	4000	1	15904.47752	0.006015748	0.005968713	0.006009756
Lettuce	100	100	2	48789.68916	0.001933195	0.001937523	0.001931416
Lettuce	100	4000	2	17857.90156	0.005215187	0.005254243	0.005267795
Lettuce Async	100	100	1	49976.97139	0.001883197	0.001898657	0.00188867
Lettuce Async	100	4000	1	24963.30556	0.003712727	0.003703818	0.003694612
Lettuce Async	100	100	2	80851.0628	0.001149271	0.00115979	0.001160054
Lettuce Async	100	4000	2	27150.45807	0.003380813	0.003363312	0.003414185

Signed-off-by: acarbonetto <[email protected]>

…is_client

Signed-off-by: acarbonetto <[email protected]>

…t-jni Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>

acarbonetto · 2023-11-01T20:36:51Z

java/benchmarks/src/main/java/javababushka/benchmarks/clients/babushka/JniNettyClient.java

+  }
+
+  public JniNettyClient(boolean async) {
+    name += async ? " async" : " sync";


probably don't need this

I use it only to distinguish clients in benchmarking.

acarbonetto · 2023-11-01T20:42:50Z

java/benchmarks/src/main/java/javababushka/benchmarks/clients/babushka/JniNettyClient.java

+  private static String getSocket() {
+    try {
+      return RedisClient.startSocketListenerExternal();
+    } catch (Exception | UnsatisfiedLinkError e) {


Exception catches everything

Nothing works without a UDS.

acarbonetto · 2023-11-01T20:45:42Z

java/benchmarks/src/main/java/javababushka/benchmarks/clients/babushka/JniNettyClient.java

+                      // TODO surround parsing with try-catch
+                      var response = Response.parseFrom(bytes);
+                      //System.out.printf("== Received response with callback %d%n", response.getCallbackIdx());
+                      responses.get(response.getCallbackIdx()).complete(response);


We should remove completed responses from the array at some point.

Can we remove them there:
https://github.com/Bit-Quill/babushka/blob/a3075d5ae3eaff3796cd0049431a2aef299fdd4b/java/benchmarks/src/main/java/javababushka/benchmarks/clients/babushka/JniNettyClient.java#L167 ?

java/benchmarks/src/main/java/javababushka/benchmarks/clients/babushka/JniNettyClient.java

Signed-off-by: Yury-Fridlyand <[email protected]>

This reverts commit e3f7596.

Signed-off-by: Yury-Fridlyand <[email protected]>

acarbonetto · 2023-11-16T01:03:45Z

java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java

@@ -148,14 +148,15 @@ public static void printResults(
  public static void testClientSetGet(
      Supplier<Client> clientCreator, BenchmarkingApp.RunConfiguration config, boolean async) {
    for (int concurrentNum : config.concurrentTasks) {
-      int iterations =
+      int iterations = 100000;


Signed-off-by: Yury-Fridlyand <[email protected]>

* Client optimizations. Signed-off-by: Yury-Fridlyand <[email protected]> * minor cleanup. Signed-off-by: Yury-Fridlyand <[email protected]> * Optimize building a command. Signed-off-by: Yury-Fridlyand <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor rename. Signed-off-by: Yury-Fridlyand <[email protected]> * Clean up Redis close connection Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up Redis close connection Signed-off-by: Andrew Carbonetto <[email protected]> * Minor changes. Signed-off-by: Yury-Fridlyand <[email protected]> * Add todos to closeConnection() Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>

…t-jni-netty Signed-off-by: Yury-Fridlyand <[email protected]>

benchmarks/utilities/csv_exporter.py

java/Cargo.toml

java/benchmarks/build.gradle

java/benchmarks/src/main/java/javababushka/benchmarks/BenchmarkingApp.java

java/client/src/main/java/javababushka/Client.java

acarbonetto · 2023-11-16T21:44:00Z

java/client/src/main/java/javababushka/Client.java

+  }
+
+  public <T> T waitForResult(Future<T> future) {
+    return waitForResult(future, DEFAULT_TIMEOUT_MILLISECONDS);


why not use the default implementation?

This client has no default implementation. The benchmarking client has it.
BTW this function is used for testing only, maybe we will remove it completely.

That would be good...

java/client/src/main/java/javababushka/RustWrapper.java

java/src/lib.rs

Signed-off-by: Yury-Fridlyand <[email protected]>

java/benchmarks/src/main/java/javababushka/benchmarks/clients/jedis/JedisClient.java

java/benchmarks/src/main/java/javababushka/benchmarks/clients/jedis/JedisPseudoAsyncClient.java

...chmarks/src/main/java/javababushka/benchmarks/clients/lettuce/LettuceAsyncClusterClient.java

acarbonetto · 2023-11-18T00:23:06Z

java/benchmarks/src/main/java/javababushka/benchmarks/utils/ConnectionSettings.java

-  public String host;
-  public int port;
-  public boolean useSsl;
+import lombok.AllArgsConstructor;


we want to use lombok?

acarbonetto · 2023-11-18T00:27:34Z

java/client/src/main/java/javababushka/Client.java

+          new Bootstrap()
+              .option(ChannelOption.WRITE_BUFFER_WATER_MARK, new WriteBufferWaterMark(1024, 4096))
+              .option(ChannelOption.ALLOCATOR, ByteBufAllocator.DEFAULT)
+              .group(group = isMacOs ? new KQueueEventLoopGroup() : new EpollEventLoopGroup())


why twice? once for group and once for channel class?

acarbonetto · 2023-11-18T00:28:35Z

java/client/src/main/java/javababushka/Client.java

+                                @Override
+                                public void channelRead(ChannelHandlerContext ctx, Object msg)
+                                    throws Exception {
+                                  // System.out.printf("=== channelRead %s %s %n", ctx, msg);


Make me think we should have log levels instead of debugLogging = true/false.
If we have log levels, we can output these as trace logs.

We need to implement logging and rework this. I don't like line 214 too.

acarbonetto · 2023-11-20T20:56:20Z

java/client/src/main/java/javababushka/Client.java

+  }
+
+  public <T> T waitForResult(Future<T> future) {
+    return waitForResult(future, DEFAULT_TIMEOUT_MILLISECONDS);


That would be good...

java/client/src/main/java/javababushka/Client.java

Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>

commit b50d57e Author: Yury-Fridlyand <[email protected]> Date: Tue Nov 21 18:16:20 2023 -0800 Java client jni netty (#32) * Add Java-client benchmarking app Signed-off-by: acarbonetto <[email protected]> * spotless apply Signed-off-by: acarbonetto <[email protected]> * Update on command line options Signed-off-by: acarbonetto <[email protected]> * Update README Signed-off-by: acarbonetto <[email protected]> * Spotless apply: Signed-off-by: acarbonetto <[email protected]> * Update README example Signed-off-by: acarbonetto <[email protected]> * update commandline defaults for review comments Signed-off-by: acarbonetto <[email protected]> * Remove TLS flag argument from option Signed-off-by: acarbonetto <[email protected]> * Add lettuce clients for benchmarking Signed-off-by: acarbonetto <[email protected]> * Spotless apply Signed-off-by: acarbonetto <[email protected]> * Add Jedis clients Signed-off-by: acarbonetto <[email protected]> * Add to app Signed-off-by: acarbonetto <[email protected]> * Add for-loop for data size list Signed-off-by: acarbonetto <[email protected]> * Add TPS for all async items Signed-off-by: acarbonetto <[email protected]> * spotless apply Signed-off-by: acarbonetto <[email protected]> * Fix TPS calculations Signed-off-by: acarbonetto <[email protected]> * Accept TLS as a flag Signed-off-by: acarbonetto <[email protected]> * Start threads; then wait for results Signed-off-by: acarbonetto <[email protected]> * Add java-jni client Signed-off-by: acarbonetto <[email protected]> * Handle Exceptions from client; add JniSyncClient fixes Signed-off-by: acarbonetto <[email protected]> * Clean up latency and add error checking Signed-off-by: acarbonetto <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix result printing. Signed-off-by: Yury-Fridlyand <[email protected]> * Add TPS. Signed-off-by: Yury-Fridlyand <[email protected]> * Remove duplicates. Reorganize and fix imports. Signed-off-by: Yury-Fridlyand <[email protected]> * Int ctor fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 1. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 2: connected! Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 3: `get` and `set`. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 4: benchmark. Signed-off-by: Yury-Fridlyand <[email protected]> * Iteration 5: some fixes. Signed-off-by: Yury-Fridlyand <[email protected]> * Change number of threads in Benchmarking threadpool * Revert "Change number of threads in Benchmarking threadpool" This reverts commit e3f7596. * Add more flushing rules and UT. Signed-off-by: Yury-Fridlyand <[email protected]> * Client clean up. Signed-off-by: Yury-Fridlyand <[email protected]> * Client optimizations. (#37) * Client optimizations. Signed-off-by: Yury-Fridlyand <[email protected]> * minor cleanup. Signed-off-by: Yury-Fridlyand <[email protected]> * Optimize building a command. Signed-off-by: Yury-Fridlyand <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor rename. Signed-off-by: Yury-Fridlyand <[email protected]> * Clean up Redis close connection Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up Redis close connection Signed-off-by: Andrew Carbonetto <[email protected]> * Minor changes. Signed-off-by: Yury-Fridlyand <[email protected]> * Add todos to closeConnection() Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * Address PR feedback. Signed-off-by: Yury-Fridlyand <[email protected]> * Rename Signed-off-by: Yury-Fridlyand <[email protected]> * Rename2 Signed-off-by: Yury-Fridlyand <[email protected]> * Fix CI Signed-off-by: Yury-Fridlyand <[email protected]> * More fixes. Signed-off-by: Yury-Fridlyand <[email protected]> * Some changes. Signed-off-by: Yury-Fridlyand <[email protected]> * add null check Signed-off-by: Yury-Fridlyand <[email protected]> * autoflush Signed-off-by: Yury-Fridlyand <[email protected]> * Apply suggestions from code review Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * minor changes Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: acarbonetto <[email protected]> Co-authored-by: Jonathan Louie <[email protected]> commit bcf188c Author: acarbonetto <[email protected]> Date: Tue Nov 14 14:54:36 2023 -0800 Clean up timer Signed-off-by: acarbonetto <[email protected]> commit 05590b0 Author: Andrew Carbonetto <[email protected]> Date: Tue Nov 14 11:41:51 2023 -0800 Java benchmarks clusters (#34) * Add lettuce cluster client when cluster mode enabled --------- Signed-off-by: Andrew Carbonetto <[email protected]> commit 30f2f62 Merge: a62fe92 8a0449d Author: acarbonetto <[email protected]> Date: Mon Nov 6 14:50:51 2023 -0800 Merge branch 'main' into java_benchmarks commit a62fe92 Author: acarbonetto <[email protected]> Date: Mon Nov 6 14:50:18 2023 -0800 fix java install_and_test script variables Signed-off-by: acarbonetto <[email protected]> commit b00a205 Merge: 9cbc9c2 d533b7f Author: Yury-Fridlyand <[email protected]> Date: Wed Oct 25 11:16:12 2023 -0700 Merge branch 'java_benchmarks' of github.com:Bit-Quill/babushka into java_benchmarks Signed-off-by: Yury-Fridlyand <[email protected]> commit 9cbc9c2 Author: Yury-Fridlyand <[email protected]> Date: Wed Oct 25 11:15:46 2023 -0700 Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> commit d533b7f Author: Yury-Fridlyand <[email protected]> Date: Tue Oct 24 17:16:12 2023 -0700 Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> commit fe9bb98 Merge: c3d235a 231a229 Author: Yury-Fridlyand <[email protected]> Date: Tue Oct 24 17:13:19 2023 -0700 Merge remote-tracking branch 'upstream/main' into java_benchmarks Signed-off-by: Yury-Fridlyand <[email protected]> commit c3d235a Author: Yury-Fridlyand <[email protected]> Date: Fri Oct 20 10:06:23 2023 -0700 Add json reporting. (#10) * Add JSON reporting. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix for #26. Signed-off-by: Yury-Fridlyand <[email protected]> * Update java/benchmarks/src/main/java/javababushka/benchmarks/utils/Benchmarking.java Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> * Use `Optional`. Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR feedback. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> commit 8a0449d Author: SanHalacogluImproving <[email protected]> Date: Wed Oct 18 15:18:08 2023 -0700 Convert client count to snake case for rust benchmark. (#27) * Updated ClientCount to client_count for uniformity for rust. commit 65090b4 Author: SanHalacogluImproving <[email protected]> Date: Tue Oct 17 09:50:38 2023 -0700 Updated ClientCount to client_count for uniformity. commit 540f49a Author: Andrew Carbonetto <[email protected]> Date: Fri Oct 6 15:52:19 2023 -0700 Create clients only once per iteration (#19) Signed-off-by: acarbonetto <[email protected]> commit d99d27a Author: acarbonetto <[email protected]> Date: Fri Oct 6 14:08:29 2023 -0700 Update redis-rs to match main branch Signed-off-by: acarbonetto <[email protected]> commit 1bab56a Author: Yury-Fridlyand <[email protected]> Date: Thu Oct 5 14:01:59 2023 -0700 Add option to run tests on multiple clients in concurrency (#16) * Add option to run tests on multiple clients in concurrency * Common pool of iterations. * Awaiting result from async methods. Signed-off-by: Yury-Fridlyand <[email protected]> * minor fix Signed-off-by: Yury-Fridlyand <[email protected]> * Change while-loop; Spotless Apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: acarbonetto <[email protected]> Co-authored-by: acarbonetto <[email protected]> commit b15f93e Author: Yury-Fridlyand <[email protected]> Date: Wed Sep 27 10:02:38 2023 -0700 Add missing renames. (#17) Signed-off-by: Yury-Fridlyand <[email protected]> commit 8664d05 Author: Andrew Carbonetto <[email protected]> Date: Tue Sep 26 15:27:11 2023 -0700 Rename jabushka to javababushka (#14) Signed-off-by: acarbonetto <[email protected]> commit e57c1ff Author: Yury-Fridlyand <[email protected]> Date: Mon Sep 25 17:25:41 2023 -0700 Add dataSize option to java benchmark. (#11) * Add Jedis and Lettuce benchmarks * Start ignoring .gradle files * Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> * Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> * Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> * Add benchmarks for GET non-existing * Revert "Update gitignore and remove generated files from git" This reverts commit d9b26a6. * fix redis-rs submodules Signed-off-by: acarbonetto <[email protected]> * Randomize commands in Java benchmarks * rename chooseAction to randomAction * Add a Java benchmarking app (#7) * Add a java app to run benchmarks --------- Signed-off-by: acarbonetto <[email protected]> * Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> * Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> * Combine java pipeline and java benchmarks (#8) * Merge Pull Request #5 - Add java pipeline. Also changed: * Merged two projects. * Updated CI. * Fixed tests and updated `junit` version. * Spotless. * Add new gradle tasks. Signed-off-by: Yury-Fridlyand <[email protected]> * Add sync and async clients both to tests. (#12) * Add sync and async clients both to tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> * Add dataSize option to java benchmark. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Jonathan Louie <[email protected]> Co-authored-by: acarbonetto <[email protected]> Co-authored-by: jonathanl-bq <[email protected]> commit 016f5f6 Author: acarbonetto <[email protected]> Date: Mon Sep 25 15:10:47 2023 -0700 Move duplicated logic in benchmark JS scripts to a single file, and convert to TypeScript. (valkey-io#456) removed duplicated logic and refactored to typescript Signed-off-by: acarbonetto <[email protected]> commit 436da8f Author: Yury-Fridlyand <[email protected]> Date: Mon Sep 25 13:58:01 2023 -0700 Add sync and async clients both to tests. (#12) * Add sync and async clients both to tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> commit d526f96 Author: Yury-Fridlyand <[email protected]> Date: Thu Sep 21 17:37:59 2023 -0700 Combine java pipeline and java benchmarks (#8) * Merge Pull Request #5 - Add java pipeline. Also changed: * Merged two projects. * Updated CI. * Fixed tests and updated `junit` version. * Spotless. * Add new gradle tasks. Signed-off-by: Yury-Fridlyand <[email protected]> commit 46d0cf6 Author: acarbonetto <[email protected]> Date: Wed Sep 20 00:42:14 2023 -0700 Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> commit 6c1fb45 Author: acarbonetto <[email protected]> Date: Wed Sep 20 00:40:10 2023 -0700 Add Readme and update install_and_test script to runJava Signed-off-by: acarbonetto <[email protected]> commit 1983974 Author: Andrew Carbonetto <[email protected]> Date: Tue Sep 19 18:24:20 2023 -0700 Add a Java benchmarking app (#7) * Add a java app to run benchmarks --------- Signed-off-by: acarbonetto <[email protected]> commit 84f0efc Author: Jonathan Louie <[email protected]> Date: Thu Sep 14 16:09:11 2023 -0700 rename chooseAction to randomAction commit 52df672 Author: Jonathan Louie <[email protected]> Date: Wed Sep 13 16:04:03 2023 -0700 Randomize commands in Java benchmarks commit 5f51a5b Author: acarbonetto <[email protected]> Date: Fri Sep 8 15:47:00 2023 -0700 fix redis-rs submodules Signed-off-by: acarbonetto <[email protected]> commit cbb0dcb Author: acarbonetto <[email protected]> Date: Fri Sep 8 15:36:45 2023 -0700 Revert "Update gitignore and remove generated files from git" This reverts commit d9b26a6. commit 2a11e9a Author: Jonathan Louie <[email protected]> Date: Fri Sep 8 14:58:41 2023 -0700 Add benchmarks for GET non-existing commit e517744 Author: acarbonetto <[email protected]> Date: Fri Sep 8 13:45:34 2023 -0700 Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> commit 8203c4d Author: acarbonetto <[email protected]> Date: Fri Sep 8 13:30:53 2023 -0700 Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> commit 6ae93f5 Author: acarbonetto <[email protected]> Date: Tue Oct 3 13:35:07 2023 -0700 Update gitignore and remove generated files from git Signed-off-by: acarbonetto <[email protected]> commit 5990767 Author: Jonathan Louie <[email protected]> Date: Thu Sep 7 17:54:15 2023 -0700 Start ignoring .gradle files commit 06574ea Author: Jonathan Louie <[email protected]> Date: Wed Sep 6 20:35:12 2023 -0700 Add Jedis and Lettuce benchmarks Signed-off-by: Yury-Fridlyand <[email protected]>

acarbonetto and others added 30 commits October 10, 2023 08:23

Add Java-client benchmarking app

035ef20

Signed-off-by: acarbonetto <[email protected]>

spotless apply

0883985

Signed-off-by: acarbonetto <[email protected]>

Update on command line options

d15ade1

Signed-off-by: acarbonetto <[email protected]>

Update README

e3634ba

Signed-off-by: acarbonetto <[email protected]>

Spotless apply:

500a043

Signed-off-by: acarbonetto <[email protected]>

Update README example

0bf1678

Signed-off-by: acarbonetto <[email protected]>

update commandline defaults for review comments

12efc63

Signed-off-by: acarbonetto <[email protected]>

Remove TLS flag argument from option

951aa8b

Signed-off-by: acarbonetto <[email protected]>

Add lettuce clients for benchmarking

adc0bb6

Signed-off-by: acarbonetto <[email protected]>

Spotless apply

9fc9022

Signed-off-by: acarbonetto <[email protected]>

Add Jedis clients

111fc26

Signed-off-by: acarbonetto <[email protected]>

Add to app

9236e9a

Signed-off-by: acarbonetto <[email protected]>

Add for-loop for data size list

49654c3

Signed-off-by: acarbonetto <[email protected]>

Add TPS for all async items

b3284c1

Signed-off-by: acarbonetto <[email protected]>

spotless apply

8f1dfa5

Signed-off-by: acarbonetto <[email protected]>

Fix TPS calculations

7f690cf

Signed-off-by: acarbonetto <[email protected]>

Accept TLS as a flag

d00a655

Signed-off-by: acarbonetto <[email protected]>

Merge branch 'java-client/add_benchmark_app' into java-client/add_jed…

b5e9a33

…is_client

Merge branch 'java-client/add_jedis_client' into java-client/add_tps

3cee673

Start threads; then wait for results

8dcfec0

Signed-off-by: acarbonetto <[email protected]>

Add java-jni client

a615f8a

Signed-off-by: acarbonetto <[email protected]>

Handle Exceptions from client; add JniSyncClient fixes

73c448f

Signed-off-by: acarbonetto <[email protected]>

Clean up latency and add error checking

79459f5

Signed-off-by: acarbonetto <[email protected]>

Merge remote-tracking branch 'origin/java_benchmarks' into java-clien…

917dd0e

…t-jni Signed-off-by: Yury-Fridlyand <[email protected]>

Minor fixes.

9e62324

Signed-off-by: Yury-Fridlyand <[email protected]>

Fix result printing.

11a78a3

Signed-off-by: Yury-Fridlyand <[email protected]>

Add TPS.

a2c2670

Signed-off-by: Yury-Fridlyand <[email protected]>

Remove duplicates. Reorganize and fix imports.

4b9f8de

Signed-off-by: Yury-Fridlyand <[email protected]>

Int ctor fix.

d6b72ac

Signed-off-by: Yury-Fridlyand <[email protected]>

Iteration 1.

58f7b58

Signed-off-by: Yury-Fridlyand <[email protected]>

Yury-Fridlyand requested review from acarbonetto, Elen-Ghulam and SanHalacogluImproving November 1, 2023 19:36

acarbonetto reviewed Nov 1, 2023

View reviewed changes

Yury-Fridlyand and others added 4 commits November 1, 2023 18:47

Iteration 5: some fixes.

5f10964

Signed-off-by: Yury-Fridlyand <[email protected]>

Change number of threads in Benchmarking threadpool

e3f7596

Revert "Change number of threads in Benchmarking threadpool"

49c9119

This reverts commit e3f7596.

Add more flushing rules and UT.

dd7413b

Signed-off-by: Yury-Fridlyand <[email protected]>

acarbonetto reviewed Nov 16, 2023

View reviewed changes

Yury-Fridlyand and others added 3 commits November 15, 2023 17:48

Client clean up.

a70c907

Signed-off-by: Yury-Fridlyand <[email protected]>

Merge remote-tracking branch 'origin/java_benchmarks' into java-clien…

bb9097b

…t-jni-netty Signed-off-by: Yury-Fridlyand <[email protected]>

Yury-Fridlyand changed the base branch from java-client-jni to java_benchmarks November 16, 2023 21:02

Yury-Fridlyand marked this pull request as ready for review November 16, 2023 21:02

acarbonetto reviewed Nov 16, 2023

View reviewed changes

Yury-Fridlyand added 8 commits November 16, 2023 15:41

Address PR feedback.

2f8f93a

Signed-off-by: Yury-Fridlyand <[email protected]>

Rename

f0f0e79

Signed-off-by: Yury-Fridlyand <[email protected]>

Rename2

06ca6b4

Signed-off-by: Yury-Fridlyand <[email protected]>

Fix CI

33a09c0

Signed-off-by: Yury-Fridlyand <[email protected]>

More fixes.

444a28c

Signed-off-by: Yury-Fridlyand <[email protected]>

Some changes.

e11a0ee

Signed-off-by: Yury-Fridlyand <[email protected]>

add null check

29ba2a3

Signed-off-by: Yury-Fridlyand <[email protected]>

autoflush

16a8680

Signed-off-by: Yury-Fridlyand <[email protected]>

acarbonetto reviewed Nov 21, 2023

View reviewed changes

acarbonetto approved these changes Nov 21, 2023

View reviewed changes

java/client/src/main/java/javababushka/Client.java Show resolved Hide resolved

Yury-Fridlyand and others added 2 commits November 21, 2023 17:50

Apply suggestions from code review

3f47ba2

Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>

minor changes

61baa41

Signed-off-by: Yury-Fridlyand <[email protected]>

Yury-Fridlyand merged commit b50d57e into java_benchmarks Nov 22, 2023
5 checks passed

Yury-Fridlyand deleted the java-client-jni-netty branch November 22, 2023 02:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java client jni netty #32

Java client jni netty #32

Yury-Fridlyand commented Nov 1, 2023 •

edited

Loading

acarbonetto Nov 1, 2023

Yury-Fridlyand Nov 1, 2023

acarbonetto Nov 1, 2023

Yury-Fridlyand Nov 2, 2023

acarbonetto Nov 1, 2023

Yury-Fridlyand Nov 1, 2023

acarbonetto Nov 16, 2023

acarbonetto Nov 16, 2023

Yury-Fridlyand Nov 17, 2023

acarbonetto Nov 20, 2023

acarbonetto Nov 18, 2023

Yury-Fridlyand Nov 22, 2023

acarbonetto Nov 18, 2023

acarbonetto Nov 18, 2023

Yury-Fridlyand Nov 22, 2023

acarbonetto Nov 20, 2023

Java client jni netty #32

Java client jni netty #32

Conversation

Yury-Fridlyand commented Nov 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yury-Fridlyand commented Nov 1, 2023 •

edited

Loading