FT.SEARCH
#423
Closed
FT.SEARCH
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanl-bq
reviewed
Oct 2, 2024
java/client/src/main/java/glide/api/models/commands/vss/FTSearchOptions.java
Show resolved
Hide resolved
| */ | ||
| @Builder.Default private final Map<String, GlideString> params = new HashMap<>(); | ||
|
|
||
| // TODO maxstale? |
There was a problem hiding this comment.
What is maxstale? I don't see it in the list of options in the Redis docs.
There was a problem hiding this comment.
Undocumented option in aws implementation.
There was a problem hiding this comment.
Hmmm, I wonder why it's not documented. Is there anyone we can ask about this?
There was a problem hiding this comment.
I found this in one of the examples. I hope it will be documented when the module comes to open source.
java/client/src/main/java/glide/api/commands/VectorSearchBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/VectorSearchBaseCommands.java
Show resolved
Hide resolved
jonathanl-bq
approved these changes
Oct 2, 2024
|
Superseded by valkey-io#2385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.aws.amazon.com/memorydb/latest/devguide/vector-search-commands-ft.search.html
depends on #422