Added Incr, IncrBy and IncrByFloat commands. (String Commands) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parameterize Python tests for both RESP2 & RESP3. * use split parameters
------------ Co-authored-by: Adan Wattad <[email protected]>
Yury-Fridlyand
approved these changes
Feb 12, 2024
* Update commandmanager to remove optional<route> argument Signed-off-by: Andrew Carbonetto <[email protected]> * Java: Add Info commands to client Signed-off-by: Andrew Carbonetto <[email protected]> * Clean tests Signed-off-by: Andrew Carbonetto <[email protected]> * Fix build.gradle Signed-off-by: Andrew Carbonetto <[email protected]> * Update to merge easier Signed-off-by: Andrew Carbonetto <[email protected]> * Spotless Signed-off-by: Andrew Carbonetto <[email protected]> * Update javadoc for info clustered Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
* Java: Add transaction commands Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up for review comments Signed-off-by: Andrew Carbonetto <[email protected]> * Fix CommandManagerTest.java Signed-off-by: Andrew Carbonetto <[email protected]> * All transactions require an argument (empty is fine) Signed-off-by: Andrew Carbonetto <[email protected]> * Add IT tests for transactions Signed-off-by: Andrew Carbonetto <[email protected]> * Renaming field Signed-off-by: Andrew Carbonetto <[email protected]> * Add IT tests for Transactions Signed-off-by: Andrew Carbonetto <[email protected]> * Update exec() command with route Signed-off-by: Andrew Carbonetto <[email protected]> * Update exec() command with route Signed-off-by: Andrew Carbonetto <[email protected]> * Remove failing tests Signed-off-by: Andrew Carbonetto <[email protected]> * Spotless Signed-off-by: Andrew Carbonetto <[email protected]> * Spotless Signed-off-by: Andrew Carbonetto <[email protected]> * Spotless Signed-off-by: Andrew Carbonetto <[email protected]> * Update cluster comments Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
approved these changes
Feb 12, 2024
| * @see <a href="https://redis.io/commands/incrby/">redis.io</a> for details. | ||
| * @param key The key to increment its value. | ||
| * @param amount The amount to increment. | ||
| * @return The value of <code>key</code> after the increment, An error is raised if <code>key |
There was a problem hiding this comment.
Suggested change
| * @return The value of <code>key</code> after the increment, An error is raised if <code>key | |
| * @return The value of <code>key</code> after the increment. An error is raised if <code>key |
| assertEquals(15, client.incrBy(key, 4).get(10, SECONDS)); | ||
| assertEquals("15", client.get(key).get(10, SECONDS)); | ||
|
|
||
| assertEquals(20.5, client.incrByFloat(key, 5.5).get(10, SECONDS)); |
There was a problem hiding this comment.
Suggested change
| assertEquals(20.5, client.incrByFloat(key, 5.5).get(10, SECONDS)); | |
| assertEquals(20.5, client.incrByFloat(key, 5.5).get()); |
Remove the timeout calls everywhere. They are not needed.
There was a problem hiding this comment.
I disagree. If something wrong happen, it may hang all rest tests.
An alternate option is to configure junit for test timeout; then we can remove timeouts from get.
SanHalacogluImproving
force-pushed
the
java/dev_SanH_add_Incr_IncrBy_IncrByFloat
branch
from
8b836a5
to
9b74df5
Compare
SanHalacogluImproving
deleted the
java/dev_SanH_add_Incr_IncrBy_IncrByFloat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.