OP-289: Adjust unit tests to handle unpacked bundles logic

BitBagCommerce · Sep 11, 2024 · 9a1f73e · 9a1f73e
1 parent e36d8a0
commit 9a1f73e
Show file tree

Hide file tree

Showing 20 changed files with 102 additions and 66 deletions.
diff --git a/src/Command/AddProductBundleItemToCartCommand.php b/src/Command/AddProductBundleItemToCartCommand.php
@@ -14,7 +14,7 @@
 use BitBag\SyliusProductBundlePlugin\Entity\ProductBundleItemInterface;
 use Sylius\Component\Core\Model\ProductVariantInterface;
 
-final class AddProductBundleItemToCartCommand
+final class AddProductBundleItemToCartCommand implements AddProductBundleItemToCartCommandInterface
 {
     public function __construct(
         private ProductBundleItemInterface $productBundleItem,

diff --git a/src/Command/AddProductBundleItemToCartCommandInterface.php b/src/Command/AddProductBundleItemToCartCommandInterface.php
@@ -0,0 +1,26 @@
+<?php
+
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
+declare(strict_types=1);
+
+namespace BitBag\SyliusProductBundlePlugin\Command;
+
+use BitBag\SyliusProductBundlePlugin\Entity\ProductBundleItemInterface;
+use Sylius\Component\Core\Model\ProductVariantInterface;
+
+interface AddProductBundleItemToCartCommandInterface
+{
+    public function getProductBundleItem(): ProductBundleItemInterface;
+
+    public function getProductVariant(): ?ProductVariantInterface;
+
+    public function setProductVariant(ProductVariantInterface $productVariant): void;
+
+    public function getQuantity(): ?int;
+}
diff --git a/src/Command/AddProductBundleToCartCommand.php b/src/Command/AddProductBundleToCartCommand.php
@@ -16,7 +16,7 @@
 
 final class AddProductBundleToCartCommand implements OrderIdentityAwareInterface, ProductCodeAwareInterface
 {
-    /** @var Collection<int, AddProductBundleItemToCartCommand> */
+    /** @var Collection<int, AddProductBundleItemToCartCommandInterface> */
     private Collection $productBundleItems;
 
     public function __construct(
@@ -42,13 +42,13 @@ public function getQuantity(): int
         return $this->quantity;
     }
 
-    /** @return Collection<int, AddProductBundleItemToCartCommand> */
+    /** @return Collection<int, AddProductBundleItemToCartCommandInterface> */
     public function getProductBundleItems(): Collection
     {
         return $this->productBundleItems;
     }
 
-    /** @param Collection<int, AddProductBundleItemToCartCommand> $productBundleItems */
+    /** @param Collection<int, AddProductBundleItemToCartCommandInterface> $productBundleItems */
     public function setProductBundleItems(Collection $productBundleItems): void
     {
         $this->productBundleItems = $productBundleItems;

diff --git a/src/Factory/AddProductBundleItemToCartCommandFactory.php b/src/Factory/AddProductBundleItemToCartCommandFactory.php
@@ -12,11 +12,12 @@
 namespace BitBag\SyliusProductBundlePlugin\Factory;
 
 use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Entity\ProductBundleItemInterface;
 
 final class AddProductBundleItemToCartCommandFactory implements AddProductBundleItemToCartCommandFactoryInterface
 {
-    public function createNew(ProductBundleItemInterface $bundleItem): AddProductBundleItemToCartCommand
+    public function createNew(ProductBundleItemInterface $bundleItem): AddProductBundleItemToCartCommandInterface
     {
         return new AddProductBundleItemToCartCommand($bundleItem);
     }

diff --git a/src/Factory/AddProductBundleItemToCartCommandFactoryInterface.php b/src/Factory/AddProductBundleItemToCartCommandFactoryInterface.php
@@ -11,10 +11,10 @@
 
 namespace BitBag\SyliusProductBundlePlugin\Factory;
 
-use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Entity\ProductBundleItemInterface;
 
 interface AddProductBundleItemToCartCommandFactoryInterface
 {
-    public function createNew(ProductBundleItemInterface $bundleItem): AddProductBundleItemToCartCommand;
+    public function createNew(ProductBundleItemInterface $bundleItem): AddProductBundleItemToCartCommandInterface;
 }
diff --git a/src/Factory/AddProductBundleToCartCommandFactory.php b/src/Factory/AddProductBundleToCartCommandFactory.php
@@ -11,14 +11,14 @@
 
 namespace BitBag\SyliusProductBundlePlugin\Factory;
 
-use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleToCartCommand;
 use BitBag\SyliusProductBundlePlugin\Dto\AddProductBundleToCartDtoInterface;
 use Doctrine\Common\Collections\Collection;
 
 final class AddProductBundleToCartCommandFactory implements AddProductBundleToCartCommandFactoryInterface
 {
-    /** @param Collection<int, AddProductBundleItemToCartCommand> $productBundleItems */
+    /** @param Collection<int, AddProductBundleItemToCartCommandInterface> $productBundleItems */
     public function createNew(
         int $orderId,
         string $productCode,

diff --git a/src/Factory/AddProductBundleToCartCommandFactoryInterface.php b/src/Factory/AddProductBundleToCartCommandFactoryInterface.php
@@ -11,14 +11,14 @@
 
 namespace BitBag\SyliusProductBundlePlugin\Factory;
 
-use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleToCartCommand;
 use BitBag\SyliusProductBundlePlugin\Dto\AddProductBundleToCartDtoInterface;
 use Doctrine\Common\Collections\Collection;
 
 interface AddProductBundleToCartCommandFactoryInterface
 {
-    /** @param Collection<int, AddProductBundleItemToCartCommand> $productBundleItems */
+    /** @param Collection<int, AddProductBundleItemToCartCommandInterface> $productBundleItems */
     public function createNew(
         int $orderId,
         string $productCode,

diff --git a/src/Factory/AddProductBundleToCartDtoFactory.php b/src/Factory/AddProductBundleToCartDtoFactory.php
@@ -11,7 +11,7 @@
 
 namespace BitBag\SyliusProductBundlePlugin\Factory;
 
-use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Dto\AddProductBundleToCartDto;
 use BitBag\SyliusProductBundlePlugin\Dto\AddProductBundleToCartDtoInterface;
 use BitBag\SyliusProductBundlePlugin\Entity\OrderItemInterface;
@@ -39,7 +39,7 @@ public function createNew(
     }
 
     /**
-     * @return AddProductBundleItemToCartCommand[]
+     * @return AddProductBundleItemToCartCommandInterface[]
      */
     private function getProcessedProductBundleItems(ProductBundleInterface $productBundle): array
     {

diff --git a/src/Factory/ProductBundleOrderItemFactory.php b/src/Factory/ProductBundleOrderItemFactory.php
@@ -11,7 +11,7 @@
 
 namespace BitBag\SyliusProductBundlePlugin\Factory;
 
-use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Entity\ProductBundleItemInterface;
 use BitBag\SyliusProductBundlePlugin\Entity\ProductBundleOrderItemInterface;
 use Sylius\Component\Resource\Factory\FactoryInterface;
@@ -43,8 +43,9 @@ public function createFromProductBundleItem(ProductBundleItemInterface $bundleIt
         return $productBundleOrderItem;
     }
 
-    public function createFromAddProductBundleItemToCartCommand(AddProductBundleItemToCartCommand $addItemToCartCommand): ProductBundleOrderItemInterface
-    {
+    public function createFromAddProductBundleItemToCartCommand(
+        AddProductBundleItemToCartCommandInterface $addItemToCartCommand,
+    ): ProductBundleOrderItemInterface {
         /** @var ProductBundleOrderItemInterface $productBundleOrderItem */
         $productBundleOrderItem = $this->decoratedFactory->createNew();
 

diff --git a/src/Factory/ProductBundleOrderItemFactoryInterface.php b/src/Factory/ProductBundleOrderItemFactoryInterface.php
@@ -11,7 +11,7 @@
 
 namespace BitBag\SyliusProductBundlePlugin\Factory;
 
-use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Entity\ProductBundleItemInterface;
 use BitBag\SyliusProductBundlePlugin\Entity\ProductBundleOrderItemInterface;
 use Sylius\Component\Resource\Factory\FactoryInterface;
@@ -20,5 +20,7 @@ interface ProductBundleOrderItemFactoryInterface extends FactoryInterface
 {
     public function createFromProductBundleItem(ProductBundleItemInterface $bundleItem): ProductBundleOrderItemInterface;
 
-    public function createFromAddProductBundleItemToCartCommand(AddProductBundleItemToCartCommand $addItemToCartCommand): ProductBundleOrderItemInterface;
+    public function createFromAddProductBundleItemToCartCommand(
+        AddProductBundleItemToCartCommandInterface $addItemToCartCommand,
+    ): ProductBundleOrderItemInterface;
 }
diff --git a/src/Form/Type/AddProductBundleItemToCartType.php b/src/Form/Type/AddProductBundleItemToCartType.php
@@ -12,6 +12,7 @@
 namespace BitBag\SyliusProductBundlePlugin\Form\Type;
 
 use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Entity\ProductInterface;
 use Sylius\Bundle\ProductBundle\Form\Type\ProductVariantChoiceType;
 use Sylius\Bundle\ProductBundle\Form\Type\ProductVariantMatchType;
@@ -35,7 +36,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
         }
 
         $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event): void {
-            /** @var AddProductBundleItemToCartCommand $data */
+            /** @var AddProductBundleItemToCartCommandInterface $data */
             $data = $event->getData();
 
             $form = $event->getForm();

diff --git a/src/Handler/AddProductBundleToCartHandler/CartProcessor.php b/src/Handler/AddProductBundleToCartHandler/CartProcessor.php
@@ -35,7 +35,7 @@ public function process(
         OrderInterface $cart,
         ProductBundleInterface $productBundle,
         int $quantity,
-        Collection $productBundleOrderItems,
+        Collection $addBundleItemToCartCommands,
     ): void {
         Assert::greaterThan($quantity, 0);
 
@@ -49,7 +49,7 @@ public function process(
         $cartItem = $this->cartItemFactory->createWithVariant($productVariant);
         $this->orderItemQuantityModifier->modify($cartItem, $quantity);
 
-        foreach ($productBundleOrderItems as $addBundleItemToCartCommand) {
+        foreach ($addBundleItemToCartCommands as $addBundleItemToCartCommand) {
             $productBundleOrderItem = $this->productBundleOrderItemFactory->createFromAddProductBundleItemToCartCommand($addBundleItemToCartCommand);
             $cartItem->addProductBundleOrderItem($productBundleOrderItem);
         }

diff --git a/src/Handler/AddProductBundleToCartHandler/CartProcessorInterface.php b/src/Handler/AddProductBundleToCartHandler/CartProcessorInterface.php
@@ -21,6 +21,6 @@ public function process(
         OrderInterface $cart,
         ProductBundleInterface $productBundle,
         int $quantity,
-        Collection $productBundleOrderItems,
+        Collection $addBundleItemToCartCommands,
     ): void;
 }
diff --git a/src/Provider/AddProductBundleItemToCartCommandProvider.php b/src/Provider/AddProductBundleItemToCartCommandProvider.php
@@ -11,7 +11,7 @@
 
 namespace BitBag\SyliusProductBundlePlugin\Provider;
 
-use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Entity\ProductBundleItemInterface;
 use BitBag\SyliusProductBundlePlugin\Factory\AddProductBundleItemToCartCommandFactoryInterface;
 use BitBag\SyliusProductBundlePlugin\Repository\ProductBundleItemRepositoryInterface;
@@ -32,7 +32,7 @@ public function __construct(
     }
 
     /**
-     * @return Collection<int, AddProductBundleItemToCartCommand>
+     * @return Collection<int, AddProductBundleItemToCartCommandInterface>
      *
      * @throws \Exception
      */
@@ -58,7 +58,7 @@ public function provide(string $bundleCode, array $overwrittenVariants): Collect
     }
 
     private function overwriteVariant(
-        AddProductBundleItemToCartCommand $command,
+        AddProductBundleItemToCartCommandInterface $command,
         ProductBundleItemInterface $bundleItem,
         array $overwrittenVariants,
     ): void {

diff --git a/src/Provider/AddProductBundleItemToCartCommandProviderInterface.php b/src/Provider/AddProductBundleItemToCartCommandProviderInterface.php
@@ -11,11 +11,11 @@
 
 namespace BitBag\SyliusProductBundlePlugin\Provider;
 
-use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use Doctrine\Common\Collections\Collection;
 
 interface AddProductBundleItemToCartCommandProviderInterface
 {
-    /** @return Collection<int, AddProductBundleItemToCartCommand> */
+    /** @return Collection<int, AddProductBundleItemToCartCommandInterface> */
     public function provide(string $bundleCode, array $overwrittenVariants): Collection;
 }
diff --git a/tests/Unit/Factory/AddProductBundleItemToCartCommandFactoryTest.php b/tests/Unit/Factory/AddProductBundleItemToCartCommandFactoryTest.php
@@ -11,7 +11,7 @@
 
 namespace Tests\BitBag\SyliusProductBundlePlugin\Unit\Factory;
 
-use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommand;
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Factory\AddProductBundleItemToCartCommandFactory;
 use PHPUnit\Framework\TestCase;
 use Tests\BitBag\SyliusProductBundlePlugin\Unit\MotherObject\ProductBundleItemMother;
@@ -25,6 +25,6 @@ public function testCreateAddProductBundleItemToCartCommand(): void
         $factory = new AddProductBundleItemToCartCommandFactory();
         $command = $factory->createNew($productBundleItem);
 
-        self::assertInstanceOf(AddProductBundleItemToCartCommand::class, $command);
+        self::assertInstanceOf(AddProductBundleItemToCartCommandInterface::class, $command);
     }
 }
diff --git a/tests/Unit/Factory/AddProductBundleToCartCommandFactoryTest.php b/tests/Unit/Factory/AddProductBundleToCartCommandFactoryTest.php
@@ -11,8 +11,10 @@
 
 namespace Tests\BitBag\SyliusProductBundlePlugin\Unit\Factory;
 
+use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleItemToCartCommandInterface;
 use BitBag\SyliusProductBundlePlugin\Command\AddProductBundleToCartCommand;
 use BitBag\SyliusProductBundlePlugin\Factory\AddProductBundleToCartCommandFactory;
+use Doctrine\Common\Collections\ArrayCollection;
 use PHPUnit\Framework\TestCase;
 use Tests\BitBag\SyliusProductBundlePlugin\Unit\MotherObject\AddProductBundleToCartDtoMother;
 
@@ -26,13 +28,17 @@ final class AddProductBundleToCartCommandFactoryTest extends TestCase
 
     public function testCreateAddProductBundleToCartCommandObject(): void
     {
+        $addProductBundleItemToCartCommand = $this->createMock(AddProductBundleItemToCartCommandInterface::class);
+        $commands = new ArrayCollection([$addProductBundleItemToCartCommand]);
+
         $factory = new AddProductBundleToCartCommandFactory();
-        $command = $factory->createNew(self::ORDER_ID, self::PRODUCT_CODE, self::QUANTITY);
+        $command = $factory->createNew(self::ORDER_ID, self::PRODUCT_CODE, self::QUANTITY, $commands);
 
         self::assertInstanceOf(AddProductBundleToCartCommand::class, $command);
         self::assertEquals(self::ORDER_ID, $command->getOrderId());
         self::assertEquals(self::PRODUCT_CODE, $command->getProductCode());
         self::assertEquals(self::QUANTITY, $command->getQuantity());
+        self::assertEquals($commands, $command->getProductBundleItems());
     }
 
     public function testCreateAddProductBundleToCartCommandObjectFromDto(): void