Merge pull request #38 from BitBagCommerce/dependency_injection_param…

…eter move parameters setup to di
BitBagCommerce · Nov 2, 2020 · ac9e5c5 · ac9e5c5
2 parents 1fd574d + 22b0ea7
commit ac9e5c5
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -104,6 +104,7 @@ $ bin/console debug:container | grep bitbag_sylius_wishlist_plugin
 ### Parameters you can override in your parameters.yml(.dist) file
 ```yml
 $ bin/console debug:container --parameters | grep bitbag
+$ bin/console debug:container --parameters | grep wishlist
 ```
 
 ## Testing

diff --git a/src/DependencyInjection/BitBagSyliusWishlistExtension.php b/src/DependencyInjection/BitBagSyliusWishlistExtension.php
@@ -18,6 +18,7 @@ public function load(array $config, ContainerBuilder $container): void
         $loader = new YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $this->registerResources('bitbag_sylius_wishlist_plugin', 'doctrine/orm', $config['resources'], $container);
         $loader->load('services.yml');
+        $container->setParameter('wishlist_cookie_token', $config['wishlist_cookie_token']);
     }
 
     public function prepend(ContainerBuilder $container): void

diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -23,6 +23,10 @@ public function getConfigTreeBuilder(): TreeBuilder
         $rootNode = $treeBuilder->getRootNode();
         $rootNode
             ->children()
+            ->scalarNode('wishlist_cookie_token')
+            ->defaultValue('wishlist_cookie_token')
+            ->cannotBeEmpty()
+            ->end()
             ->arrayNode('resources')
             ->addDefaultsIfNotSet()
             ->children()

diff --git a/src/Resources/config/config.yml b/src/Resources/config/config.yml
@@ -1,6 +1,3 @@
-parameters:
-    wishlist_cookie_token: bitbag_sylius_wishlist
-
 imports:
     - { resource: "@BitBagSyliusWishlistPlugin/Resources/config/services.yml" }
     - { resource: "@BitBagSyliusWishlistPlugin/Resources/config/resources.yml" }
diff --git a/tests/Application/config/packages/_sylius.yaml b/tests/Application/config/packages/_sylius.yaml
@@ -1,11 +1,8 @@
 imports:
     - { resource: "@SyliusCoreBundle/Resources/config/app/config.yml" }
-
     - { resource: "@SyliusAdminBundle/Resources/config/app/config.yml" }
     - { resource: "@SyliusAdminApiBundle/Resources/config/app/config.yml" }
-
     - { resource: "@SyliusShopBundle/Resources/config/app/config.yml" }
-
     - { resource: "@SyliusApiBundle/Resources/config/app/config.yaml" }
 
 parameters: