Fix the variant price json output #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senghe
requested changes
Oct 30, 2023
| {%- else -%} | ||
| "" | ||
| "{{ value }}" |
There was a problem hiding this comment.
We cannot just display the value, as there are i.e. arrays of CatalogPromotions etc.
|
I see there is no change since my previous comment. I'm kindly closing this PR. Please open it when it'll be more current. |
Thanks @senghe for catching up. I was not able yet to check it any further. Hope to have some time soon. Will let you know if I have any updates on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the variant price json output for the data-bb-pricing html data attribute (#225)