wasm: add a close() method #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes the connection and calls the onCloseCb callback. The callback is called manually for webHID (the webHID disconnect callback is not fired on close), and automatically for the bridge (the socket onclose event is automatically firex on close). This allows one to create a short lived connection (release the BitBox02 after performing the desired operation). This is helpful in webclients such as Rabby where one only needs to open a quick connection to e.g. sign a transaction. This only applies to WASM, not to Rust. In Rust, one can close the connection by simply dropping the object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes the connection and calls the onCloseCb callback. The callback is called manually for webHID (the webHID disconnect callback is not fired on close), and automatically for the bridge (the socket onclose event is automatically firex on close).
This allows one to create a short lived connection (release the BitBox02 after performing the desired operation). This is helpful in webclients such as Rabby where one only needs to open a quick connection to e.g. sign a transaction.
This only applies to WASM, not to Rust. In Rust, one can close the connection by simply dropping the object.