Preserve existing ENV variables if they exist #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that existing ENV variables take priority over those inside the .env file, this means we can still do ``` FOO=bar mix phx.server ``` ... and the command line FOO will take priority over the .env FOO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR ensures that existing environment variables take priority over those inside the
.envfile, this allows us to override the.envfile values with command line values, e.g.... and the command line
FOO=barwill take priority over any instance ofFOOin the.envfilePriority
Note that because of this change in behavior I also needed to swap around the priority of the
.env.#{current_env}file in order to ensure that version continues to take priority over the more generic.envvariation (to maintain the existing behavior). The new order loads the env specific version first and now if a variable is set by that variant it takes priority over the generic.env. E.g the priority order is now:.env.#{current_env}variant (if it exists).envvariant.Tests
I added a new unit test to confirm this behavior. All existing tests still pass.