Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App launcher refactor #198

Open
wants to merge 185 commits into
base: master
Choose a base branch
from
Open

App launcher refactor #198

wants to merge 185 commits into from

Conversation

Kasper24
Copy link
Contributor

@Kasper24 Kasper24 commented Feb 4, 2023 •
edited
Loading

This PR fixes lots of the issues the app launcher previously had, including:

  • Fixed scrolling issues
  • Added widget_template support - the only requirements are that the user pass in a prompt with an id of "prompt_role" and a grid with an id of "grid_role"
  • Added app_template support, this is a function that gets an app parameter passed to it. It needs to return a new widget. You can use the app table that gets passed to the function
    • Removed the animation props, as it was somewhat buggy. In the example below I show a better way of animating the widget
  • Removed most of the styling props as there's no need for them now that we have proper templates
  • Renamed bling::app_launcher::visibility signal to visibility
  • Refactor the icon theme helper so it's more consistent with the rest of the helpers library
  • Removed the get_icon_for_client function
  • Convert any useful local function as a public method so that the behavior can be tailored to one needs
  • Added a method to dynamically set the favorite apps, which might be useful in case someone implements a context menu that has a button to toggle off the app's favorite state
  • Improved spawning non-terminal apps (some file managers would open a dialog error when opening them)
  • Improved spawning terminal apps, including auto-detecting the installed terminal so the user doesn't need to configure it anymore. It also now will change the class of the terminal to the class or name if the class isn't available on the desktop file. The second part is done with xdotool, so I'm not sure if I should keep it or not
  • Added 'page::forward', 'page::backward' and 'scroll' signals
  • New text input replacing the old prompt widget, with mouse support, text selection, more sane key binds, copy and paste, completely customizable and many more
  • Better searching
  • Improved performance when scrolling by caching the widgets
  • An option to lazy load the app widgets (less ram when starting and faster startup time, but scrolling pages will lag until all the widgets have been loaded to the cache)
  • Many more bug fixes and code improvements

@javacafe01 javacafe01 mentioned this pull request Feb 8, 2023
Closed
@Kasper24
Add context to the unfocus signal
566a5a9
@Kasper24
Fix getting the same value twice
92df6d9
@Kasper24
Better handling for when clicked position it outsidd the bounds
0c6a1ca
@Kasper24
Fix cursor blinking too fast sometimes
070150e
@Kasper24
Fix #92df6d97958df14ca82b47e2de6df086be218969
ff8af15
@Kasper24
Hide scrollbar when grid is empty
6a52784
@Kasper24
I was keeping the cache, but overriding the entries table which cause…
d09bf3b 
…d the widgets to keep a refrence to an entry that was now nil
@Kasper24
Handle favorites directly in the rofi grid widget
331712f
@Kasper24
Add default_search_sort_fn and default_search_fn to rofi grid
aa25cfd
@Kasper24
Add context to the select signal
35611e4
@Kasper24
Make use of #35611e
bbba4cd
@Kasper24
Improve text selection handling when cursor it outside text extents
053cb47
@Kasper24
Can't select text if empty
cbc6f46
@Kasper24
Change default click timeout to 0.1
7d4afec
@Kasper24
This wasn't working if the mouse left the text input before releasing…
36cd158 
… LMB
@Kasper24
Only set the mode to overwrite if there was actual text being selected
86f5382
@Kasper24
Increase click timeout
69dd122
@Kasper24
Fix cursor reblinking when already in insert mode and pressing the te…
ee5438c 
…xt input again
@Kasper24
Implmement the select_or_exec function at the rofi grid widget level
80b9062
@Kasper24
Remove whitespace
92ff783
@Kasper24
Forgot to commit this
e80db42
@Kasper24
Fix text obscure
0452b69
@Kasper24
Fix cursor position after overwriting text
d8897a2
@Kasper24
Improve dragging handling
c44dc01
@chuck-flowers chuck-flowers mentioned this pull request Jun 4, 2023
Closed
Ofek Itscovits added 3 commits June 28, 2023 17:52
Fix using the wrong key
17d171e
Refresh the app list everytime :show() is called
f96d837 
Watching the /usr/share/applications directory doesn't work across all distors, i.e on NixOS
That folder exists on /run/current-system/sw/share/applications or (~/.nix-profile/share/applications for user apps), but it's
just a syslink
to a path in the store, and that path changes across rebuilts.
Use uid instead of name to identify if an entry already exists
b4cb55a 
Some apps have the same name, i.e nemo and nautilus are both called 'Files'
Before this fix only one of them would end up in the app launcher
@Kasper24 Kasper24 mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javacafe01 javacafe01 javacafe01 requested changes

Assignees
No one assigned
Labels
changes requested Requested changes from author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kasper24 @javacafe01