Update for compatibility with omniauth-oauth2 1.4 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp615
changed the title
ghost
merged commit 
|
Works great and solves the bug, thanks for this! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in omniauth/omniauth-oauth2#81 and #3, version 1.4 of omniauth-oauth2 has an issue with query params being broken. Previously it overrode the callback_url, but now it no longer matches, causing all callbacks to fail.
This patch should fix the functionality to allow maximum compatibility with other versions. It's basically what many other strategy authors have done. Hope that helps!