Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changePrizePool correctly #15

Closed
lordshashank opened this issue Jan 17, 2024 · 9 comments
Closed

Implement changePrizePool correctly #15

lordshashank opened this issue Jan 17, 2024 · 9 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers smart contracts Issue related to smart contracts

Comments

@lordshashank
Copy link
Collaborator

current implementation of changePrizePool is not optimal. It just increases the prize pool and that also without updating the prize structs.
Re-implement the function as two functions changePoolPrize and changePrizeArray implementing prize changes for sponsors along with updating the relevant structs.

@lordshashank lordshashank added bug Something isn't working good first issue Good for newcomers smart contracts Issue related to smart contracts labels Jan 17, 2024
@yomanthunder
Copy link
Contributor

I would like to solve the issue

@lordshashank
Copy link
Collaborator Author

sure, just make sure to follow the contributing guidlines.

@yomanthunder
Copy link
Contributor

yomanthunder commented Jan 22, 2024

@lordshashank
i have just added one function that was asked to implement in the issue changePrizeArray, but as the contract is very big , Contract code size is exceeding exceeds 24576 bytes (a limit introduced in Spurious Dragon)

what should i do about it ??

@lordshashank
Copy link
Collaborator Author

try to increase optimizer runs to 2000 if it helps.

@lordshashank
Copy link
Collaborator Author

It would not help in long go, comment out the getter functions for public vars as of now (as public vars have their own getter functions) and implement the team functionality. I guess we would have to shift to interfaces for different functionalities, would keep that for another patch.

@yomanthunder
Copy link
Contributor

yomanthunder commented Jan 22, 2024

@lordshashank
I think raising a new issue for the teams functionality will be a good idea
Please do specify how you want to implement the teams feature in that issue

  1. Team Structure:
    How should teams be structured and created within the contract?
  2. Roles and Permissions:
  • What roles do you envision within a team, and what permissions should each role have?
  1. Team Interactions:
  2. Events and Notifications:

@lordshashank
Copy link
Collaborator Author

The issue is already there #16 , this issue is independent of that, here our aim is to give an option to sponsor to change the prize distribution in main prize and pool prize, this should be pretty straight forward.

@yomanthunder
Copy link
Contributor

@lordshashank, I would greatly appreciate your feedback on my pull request. It's my first contribution, and I'm eager to learn and improve. Please let me know if there are any areas that need attention or if you have any suggestions. Thank you!

@lordshashank
Copy link
Collaborator Author

Resolved here #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers smart contracts Issue related to smart contracts
Projects
None yet
Development

No branches or pull requests

2 participants