-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changePrizePool and changePrizeArray implimented #29
changePrizePool and changePrizeArray implimented #29
Conversation
oolChangePayment changePrizePool calculatePrizeArrayChangePayment changePrizeArray and basic tests
@lordshashank i think having sponsor number as a parameter make you more prone to attacks , our modifier only check whether you are a sponsor or not meaning others sponsor can tamper with my prizepool or prizearray (which can potentially be stopped with some basic code but makes things more complicated tho) |
@yomanthunder , this makes sense, your implementation would be good for now. Just do following two improvements.
|
@lordshashank I have made the required changes , you can merge the pull request |
LFG🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOOD TO GO
Resolving #15