Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/consensus/database.go #23 #33

Conversation

VeerChaurasia
Copy link

Implemented Database.go

@star-gazer111
Copy link
Member

@VeerChaurasia is this PR ready for review?

@VeerChaurasia
Copy link
Author

@VeerChaurasia is this PR ready for review?

If i had to only implement database then yes

@star-gazer111
Copy link
Member

Implemented Database.go

consensus types are already implemented here #25 right?

@VeerChaurasia
Copy link
Author

Implemented Database.go

consensus types are already implemented here #25 right?

Yes the files are beacon.go and basic.go

@star-gazer111
Copy link
Member

@VeerChaurasia the linter workflow is failing in this. Did u run the linter at your own end?

@VeerChaurasia
Copy link
Author

@VeerChaurasia the linter workflow is failing in this. Did u run the linter at your own end?
there is no problem at my side I think as the database.go doesn't need any field from consensus_core.go(in consensus_core.go every field is private maybe this is hwy the whole linter workflow is failing)

@star-gazer111
Copy link
Member

@VeerChaurasia the linter workflow is failing in this. Did u run the linter at your own end?
there is no problem at my side I think as the database.go doesn't need any field from consensus_core.go(in consensus_core.go every field is private maybe this is hwy the whole linter workflow is failing)

we are also getting errors in beacon.go & types.go as well. Ig we might need another round of cleanup before execution starts getting merged.

@star-gazer111 star-gazer111 merged commit 9f589f2 into BlocSoc-iitr:dev Sep 19, 2024
3 of 4 checks passed
@VeerChaurasia
Copy link
Author

Yes some of the structs are still not exportable even some functions ig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants