Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Applying usage of ResponseEntity and HTTPStatus #19

Merged
merged 14 commits into from
May 28, 2024
Merged

Conversation

jimin-kiim
Copy link
Member

@jimin-kiim jimin-kiim commented May 28, 2024

Summary

  • created Status and ResponseDTO to manage the status code, status message and the structure of the body in more organized way.

Test

SwaggerUI Postman
스크린샷 2024-05-29 오전 12 13 28

PR Point

  • Status: in order to manage the HttpStatus Code and the message together
  • ResponseEntity: in order to set the status code and the body
  • ResponseDTO: in order to make and use the organized structure of body
  • dilemma: using ResponseEntity seems to weaken the effect of using swaggerUI. it hides the structure of the response. It seems necessary to consider which method is better

Related

@jimin-kiim jimin-kiim merged commit 17ef636 into main May 28, 2024
1 check passed
@jimin-kiim jimin-kiim deleted the feat/#18 branch May 28, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applying using ResponseEntity and HTTPStatus
1 participant