CodeClimate re-integration #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinomen
requested changes
Mar 25, 2022
| @@ -25,6 +25,21 @@ jobs: | |||
| - name: Install dependencies | |||
| run: npm install | |||
| - run: npm run lint | |||
| test: | |||
There was a problem hiding this comment.
I agree, we don't need both test and coverage. Let's just merge these so the test run will upload to CC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up merging some trivial test updates so now that we're wired up again I'm ready to reinclude the test step.
@tinomen and @ashtilawat23 I don't know that we need both a test step and coverage step. But I'll differ to y'all on that idea.
This PR simply adds the steps in the build to publish back the coverage report from jest to Code Climate.
If you install the CodeClimate browser extension you should see those badges 👆 at the top of the repo page.